Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment count to Disqus #40

Open
jwillmer opened this issue Jun 1, 2017 · 7 comments
Open

Add comment count to Disqus #40

jwillmer opened this issue Jun 1, 2017 · 7 comments
Assignees
Milestone

Comments

@jwillmer
Copy link
Owner

jwillmer commented Jun 1, 2017

I thought about changing the "Load comments" into "Load 5 Comments" to give an indication how much comments are there. The goal is to do this without loading the whole Disqus overhead. Turns out, someone did it already and inspecting his demo (use raymondcamden and open dev tools) I can see that Disqus does not load any bloatware.

Let's implement it? @alexsimo

@alxsimo
Copy link
Collaborator

alxsimo commented Jun 1, 2017

Not bad idea! But would be the flow? an infinite scroll? or maybe the user will need to click the button every time wants 5 more comments?

@jwillmer
Copy link
Owner Author

jwillmer commented Jun 1, 2017

No, sorry, my example is misleading. I only like to show that are a number N amount of comments already. So I know if there are comments I can read.

Load Comment Section (5💬)

@alxsimo
Copy link
Collaborator

alxsimo commented Jun 1, 2017

Oh! Understood now! Yes! Looks good for me!
I'll assign myself but not sure when can make it.

@alxsimo
Copy link
Collaborator

alxsimo commented Jun 1, 2017

Seems I can't do it myself. Assign me please

@jwillmer
Copy link
Owner Author

jwillmer commented Jun 2, 2017

Strange, I can't find you in the assignee drop-down. I wrote GitHub support to have a look. I will assign you as soon as I can ☝️

@jwillmer
Copy link
Owner Author

jwillmer commented Jun 2, 2017

From the support team:

This has to do with the fact that the user opened that original issue and it can therefore be assigned to him, versus in this case, you opened the issue and the user is not a collaborator and thus can't be assigned to the issue.

I can promote you to collaborator if you don't mind to still use pull requests and not commit directly.

@alxsimo
Copy link
Collaborator

alxsimo commented Jun 2, 2017 via email

@jwillmer jwillmer added this to the Road to version 1.1.9 milestone Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants