Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to specify options --reuse-values, --reset-values? #174

Closed
ahebibovic opened this issue Feb 13, 2023 · 4 comments
Closed

Comments

@ahebibovic
Copy link

https://github.com/k3s-io/helm-controller/blob/master/pkg/apis/helm.cattle.io/v1/types.go#L32

I guess it can be done like this: #143

Thanks!

@brandond
Copy link
Member

No, but I'm not sure these options would really be necessary, since all the values are persisted in the HelmChart and HelmChartValues resources themselves... given that the values are persisted externally, what would the use case be for using those options?

@ahebibovic
Copy link
Author

I am going to use that from there. Thanks!

@oivindoh
Copy link

oivindoh commented Sep 8, 2023

A use-case I can think of is if there's an issue with an image used by a helm chart, so you've overridden the image in your HelmChartConfig, but then the project releases a new chart version that points to a fixed image and you want to go back to using whichever image the chart specifies. Currently the previous value is sticky unless you explicitly set a new one, so new defaults are impossible to apply.

@brandond
Copy link
Member

brandond commented Sep 8, 2023

@oivindoh
so you've overridden the image in your HelmChartConfig, but then the project releases a new chart version that points to a fixed image and you want to go back to using whichever image the chart specifies. Currently the previous value is sticky unless you explicitly set a new one, so new defaults are impossible to apply.

I don't believe that's true. Chart values ARE NOT sticky; the helm upgrade command is not run with --reuse-values, so if you remove the value from your HelmChartConfig, the chart will be redeployed without your custom value, and go back to using the chart default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants