Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

found a bug about scan mysql rows #313

Open
wangyanphp opened this issue Jul 25, 2024 · 4 comments
Open

found a bug about scan mysql rows #313

wangyanphp opened this issue Jul 25, 2024 · 4 comments

Comments

@wangyanphp
Copy link

wangyanphp commented Jul 25, 2024 •
edited
Loading

https://github.com/k3s-io/kine/blob/master/pkg/logstructured/sqllog/sql.go#L353
image
it should check rows.Error when finished rows.Next loop
@wangyanphp wangyanphp changed the title find a bug find a bug about scan mysql rows Jul 25, 2024
@wangyanphp wangyanphp changed the title find a bug about scan mysql rows found a bug about scan mysql rows Jul 25, 2024
@brandond
Copy link
Member

Can you show an error caused by not doing this? Or some way to cause one?

@wangyanphp
Copy link
Author

Can you show an error caused by not doing this? Or some way to cause one?

mysql error code 1160 can cause this

@brandond
Copy link
Member

brandond commented Jul 25, 2024 •
edited
Loading

In case of a communication problem with the sql server, there would be additional errors that are handled outside the row iterator, right?

@wangyanphp
Copy link
Author

In case of a communication problem with the sql server, there would be additional errors that are handled outside the row iterator, right?

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandond @wangyanphp