Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a name of instance or volume etc is given wrong, have to delete and create one with correct fields. #37

Open
vatsa287 opened this issue Dec 27, 2022 · 1 comment
Open

If a name of instance or volume etc is given wrong, have to delete and create one with correct fields. #37

vatsa287 opened this issue Dec 27, 2022 · 1 comment

Comments

@vatsa287
Copy link
Contributor

Is it feasible to provide an option to edit alongside delete dropdown? Or atleast for console?

  • Can be done by sending delete API of older data & another one with Update API with newer data.
  • Add a check to forbid editing top level data. ex. Forbid to change pool or node name while changing volume name.
@aravindavk
Copy link
Member

Instance details are saved in Browser's local storage. Rename/Edit instance can be added. Edit Pool/Volume depends on Rename Pool/Volume APIs.

vatsa287 added a commit to vatsa287/console that referenced this issue Dec 30, 2022
@vatsa287
templates: Add option to edit mgr instance stored in localstorage
6697309 
Updates: kadalu-tech#37
Signed-off-by: Shree Vatsa N <[email protected]>
@vatsa287 vatsa287 mentioned this issue Dec 30, 2022
Merged
aravindavk pushed a commit that referenced this issue Jan 1, 2023
@vatsa287
templates: Add option to edit mgr instance stored in localstorage (#38)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
da9be99 
* templates: Add option to edit mgr instance stored in localstorage
* add edit icon

Updates: #37
Signed-off-by: Shree Vatsa N <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aravindavk @vatsa287