diff --git a/.github/workflows/run_tests.yaml b/.github/workflows/run_tests.yaml index bc805b1..6fe5e1f 100644 --- a/.github/workflows/run_tests.yaml +++ b/.github/workflows/run_tests.yaml @@ -11,6 +11,18 @@ jobs: tests: uses: kaltura/playkit-js-common/.github/workflows/cypress.yml@master secrets: inherit + build: + uses: kaltura/ovp-pipelines-pub/.github/workflows/player_tests.yaml@master + with: + node-version: '18.x' + yarn-run-to-execute: 'build' + lint: + uses: kaltura/ovp-pipelines-pub/.github/workflows/player_tests.yaml@master + with: + node-version: '18.x' + yarn-run-to-execute: 'eslint' + + notification: if: always() @@ -21,5 +33,4 @@ jobs: with: failure-status: ${{ contains(needs.*.result, 'failure') }} cancelled-status: ${{ contains(needs.*.result, 'cancelled') }} - is-test: 'true' - \ No newline at end of file + is-test: 'true' \ No newline at end of file diff --git a/package.json b/package.json index 252fbda..e9cc0fb 100644 --- a/package.json +++ b/package.json @@ -13,6 +13,7 @@ "pushTaggedRelease": "git push --follow-tags --no-verify origin master", "release": "standard-version", "eslint": "eslint . --color", + "eslint:fix": "eslint . --color --fix", "prettier:fix": "prettier --write .", "cy:open": "cypress open", "cy:run": "yarn run cy:run:chrome && yarn run cy:run:firefox && yarn run cy:run:edge && yarn run cy:run:safari", diff --git a/src/components/attachments-list/attachments-list.tsx b/src/components/attachments-list/attachments-list.tsx index f1a8fb9..63d98d2 100644 --- a/src/components/attachments-list/attachments-list.tsx +++ b/src/components/attachments-list/attachments-list.tsx @@ -4,7 +4,7 @@ import {DownloadItem} from '../download-item'; import * as styles from './attachments-list.scss'; import {ComponentChildren} from 'preact'; import {getIconByFileExt} from '@playkit-js/common/dist/icon/icon-utils'; -import { assetType } from '../../consts/asset-type'; +import {assetType} from '../../consts/asset-type'; const {withText} = KalturaPlayer.ui.preacti18n; @@ -22,7 +22,16 @@ export const AttachmentsList = withText({ }; const _renderDownloadItem = (key: string, fileName: string, downloadUrl: string, icon: ComponentChildren) => { - return ; + return ( + + ); }; const _renderAttachments = (attachments: Array) => { diff --git a/src/components/captions-list/captions-list.tsx b/src/components/captions-list/captions-list.tsx index a9bda87..31e8f97 100644 --- a/src/components/captions-list/captions-list.tsx +++ b/src/components/captions-list/captions-list.tsx @@ -4,7 +4,7 @@ import {DownloadItem} from '../download-item'; import * as styles from './captions-list.scss'; import {ExpandableContainer} from '../expandable-container'; import {Icon as CommonIcon} from '@playkit-js/common/dist/icon'; -import { assetType } from '../../consts/asset-type'; +import {assetType} from '../../consts/asset-type'; const {withText} = KalturaPlayer.ui.preacti18n; diff --git a/src/components/sources-list/sources-list.tsx b/src/components/sources-list/sources-list.tsx index 05a134c..9b9633e 100644 --- a/src/components/sources-list/sources-list.tsx +++ b/src/components/sources-list/sources-list.tsx @@ -6,7 +6,7 @@ import {DownloadConfig} from '../../types'; import {ExpandableContainer} from '../expandable-container'; import {ComponentChildren} from 'preact'; import {Icon as CommonIcon} from '@playkit-js/common/dist/icon'; -import { assetType } from '../../consts/asset-type'; +import {assetType} from '../../consts/asset-type'; const {Icon, IconType} = KalturaPlayer.ui.components; const {withText} = KalturaPlayer.ui.preacti18n; @@ -149,9 +149,8 @@ export const SourcesList = withText({ return _renderDownloadItem('1', fileName, '', imageUrl, _getImageIcon(), true); } else if (flavors.length > 0) { return _renderExpandableFlavors(); - } else { - return undefined; } + return undefined; }; return ( diff --git a/src/download.tsx b/src/download.tsx index 70fcefa..4af3741 100644 --- a/src/download.tsx +++ b/src/download.tsx @@ -8,7 +8,7 @@ import {DownloadPluginManager} from './download-plugin-manager'; import {OnClickEvent} from '@playkit-js/common'; import {ui} from '@playkit-js/kaltura-player-js'; -import { DownloadEvent } from "./event"; +import {DownloadEvent} from './event'; const {ReservedPresetNames} = ui; const {Text} = ui.preacti18n; @@ -141,8 +141,8 @@ class Download extends KalturaPlayer.core.BasePlugin { } _addBindings() { - this.eventManager.listen(this.downloadPluginManager, DownloadEvent.SHOW_OVERLAY, (e) => this.dispatchEvent(DownloadEvent.SHOW_OVERLAY, e.payload)); - this.eventManager?.listen(this.downloadPluginManager, DownloadEvent.HIDE_OVERLAY, (e) => this.dispatchEvent(DownloadEvent.HIDE_OVERLAY, e.payload)); + this.eventManager.listen(this.downloadPluginManager, DownloadEvent.SHOW_OVERLAY, e => this.dispatchEvent(DownloadEvent.SHOW_OVERLAY, e.payload)); + this.eventManager?.listen(this.downloadPluginManager, DownloadEvent.HIDE_OVERLAY, e => this.dispatchEvent(DownloadEvent.HIDE_OVERLAY, e.payload)); } reset() {