From d631460bf276db9d6e8ea5ee4961bedf5f9c93a1 Mon Sep 17 00:00:00 2001 From: ovp-github-actions Date: Sun, 2 Jun 2024 07:06:59 +0000 Subject: [PATCH 1/3] chore(release): 0.84.9 --- CHANGELOG.md | 2 ++ package.json | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0db3ad93..0d4d50d3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines. +### 0.84.9 (2024-06-02) + ### 0.84.8 (2024-04-09) diff --git a/package.json b/package.json index 265e50ff..00188743 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@playkit-js/playkit-js", - "version": "0.84.8", + "version": "0.84.9", "keywords": [ "kaltura", "player", From 9293ec7c27104063ab6ead7a37333b60ecd2b741 Mon Sep 17 00:00:00 2001 From: Serhii Date: Sun, 9 Jun 2024 14:43:11 +0300 Subject: [PATCH 2/3] fix(XDR-3359): fix default caption alignment (#781) ### Description of the Changes Overwrite default caption alignment (case when caption cues has native alignment but user set custom alignment in caption menu) resolves: https://kaltura.atlassian.net/browse/FEC-13979 ### CheckLists - [ ] changes have been done against master branch, and PR does not conflict - [ ] new unit / functional tests have been added (whenever applicable) - [ ] test are passing in local environment - [ ] Travis tests are passing (or test results are not worse than on master branch :)) - [ ] Docs have been updated --- src/track/text-track-display.ts | 33 ++++++++++++++++++--------------- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/src/track/text-track-display.ts b/src/track/text-track-display.ts index 0550eae5..e5504bf4 100644 --- a/src/track/text-track-display.ts +++ b/src/track/text-track-display.ts @@ -635,13 +635,14 @@ class CueStyleBox extends StyleBox { styles.unicodeBidi = 'plaintext'; } this.applyStyles(styles, this.cueDiv); + const useDefaultAlignment = styleOptions.textAlign === 'default'; // Create an absolutely positioned div that will be used to position the cue // div. Note, all WebVTT cue-setting alignments are equivalent to the CSS // mirrors of them except "middle" which is "center" in CSS. this.div = window.document.createElement('div'); let textAlign = cue.align === 'middle' ? 'center' : cue.align; - if (styleOptions.textAlign !== 'default') { + if (!useDefaultAlignment) { textAlign = styleOptions.textAlign; } styles = { @@ -664,20 +665,22 @@ class CueStyleBox extends StyleBox { // position of the cue box. The reference edge will be resolved later when // the box orientation styles are applied. let textPos = 0; - switch (styleOptions.textAlign) { - case 'start': - case 'left': - case 'line-left': - textPos = cue.position; - break; - case 'center': - textPos = cue.position - cue.size / 2; - break; - case 'end': - case 'right': - case 'line-right': - textPos = cue.position - cue.size; - break; + if (useDefaultAlignment) { + switch (styleOptions.textAlign) { + case 'start': + case 'left': + case 'line-left': + textPos = cue.position; + break; + case 'center': + textPos = cue.position - cue.size / 2; + break; + case 'end': + case 'right': + case 'line-right': + textPos = cue.position - cue.size; + break; + } } // Horizontal box orientation; textPos is the distance from the left edge of the From 16e2d47903ec3a87ff0b450cba21f79ea69b59ed Mon Sep 17 00:00:00 2001 From: Tzipi <101048005+Tzipi-kaltura@users.noreply.github.com> Date: Tue, 18 Jun 2024 11:06:23 +0300 Subject: [PATCH 3/3] fix(SUP-43040): v7 player issues when using picture-in-picture (pop-out) (#782) Issue: In dual screen player the pip option is disabled by adding disablePictureInPicture on the video element. was done here - FEC-13591. As a result from that when clicking on the pip button error is thrown and the video is frozen Solution: Call to pip function only if disablePictureInPicture is not true Solves SUP-43040 --- src/engines/html5/html5.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/engines/html5/html5.ts b/src/engines/html5/html5.ts index 37c26d60..58a8e71c 100644 --- a/src/engines/html5/html5.ts +++ b/src/engines/html5/html5.ts @@ -559,7 +559,7 @@ export default class Html5 extends FakeEventTarget implements IEngine { // Currently it's supported in chrome and in safari. So if we consider checking support before, // we can use this flag to distinguish between the two. In the future we might need a different method. // Second condition is because flow does not support this API yet - if (document.pictureInPictureEnabled && typeof this._el.requestPictureInPicture === 'function') { + if (document.pictureInPictureEnabled && typeof this._el.requestPictureInPicture === 'function' && !this._el.disablePictureInPicture) { this._el.requestPictureInPicture().catch(error => { this.dispatchEvent( new FakeEvent(