From 77486773003c764461a90cb88294417a6921c40a Mon Sep 17 00:00:00 2001 From: TuvalSimha Date: Sun, 1 Dec 2024 17:18:22 +0200 Subject: [PATCH] Change CriticalityLevel to Dangerous when directive removed --- .changeset/spotty-cats-drive.md | 5 +++++ packages/core/__tests__/diff/directive-usage.test.ts | 4 ++-- packages/core/src/diff/changes/directive-usage.ts | 4 ++-- 3 files changed, 9 insertions(+), 4 deletions(-) create mode 100644 .changeset/spotty-cats-drive.md diff --git a/.changeset/spotty-cats-drive.md b/.changeset/spotty-cats-drive.md new file mode 100644 index 0000000000..f43c1c6472 --- /dev/null +++ b/.changeset/spotty-cats-drive.md @@ -0,0 +1,5 @@ +--- +'@graphql-inspector/core': patch +--- + +Change CriticalityLevel to Dangerous when directive removed diff --git a/packages/core/__tests__/diff/directive-usage.test.ts b/packages/core/__tests__/diff/directive-usage.test.ts index 65822271a8..7b2117046e 100644 --- a/packages/core/__tests__/diff/directive-usage.test.ts +++ b/packages/core/__tests__/diff/directive-usage.test.ts @@ -521,7 +521,7 @@ describe('directive-usage', () => { const change = findFirstChangeByPath(changes, 'Foo.external'); expect(changes.length).toEqual(1); - expect(change.criticality.level).toEqual(CriticalityLevel.Breaking); + expect(change.criticality.level).toEqual(CriticalityLevel.Dangerous); expect(change.type).toEqual('DIRECTIVE_USAGE_SCALAR_REMOVED'); expect(change.message).toEqual("Directive 'external' was removed from scalar 'Foo'"); }); @@ -612,7 +612,7 @@ describe('directive-usage', () => { const changes = await diff(a, b); const change = findFirstChangeByPath(changes, 'Foo.external'); - expect(change.criticality.level).toEqual(CriticalityLevel.Breaking); + expect(change.criticality.level).toEqual(CriticalityLevel.Dangerous); expect(change.type).toEqual('DIRECTIVE_USAGE_INTERFACE_REMOVED'); expect(change.message).toEqual("Directive 'external' was removed from interface 'Foo'"); }); diff --git a/packages/core/src/diff/changes/directive-usage.ts b/packages/core/src/diff/changes/directive-usage.ts index a1b13ad697..00e0b165d4 100644 --- a/packages/core/src/diff/changes/directive-usage.ts +++ b/packages/core/src/diff/changes/directive-usage.ts @@ -247,7 +247,7 @@ function buildDirectiveUsageInterfaceRemovedMessage( export function directiveUsageInterfaceRemovedFromMeta(args: DirectiveUsageInterfaceRemovedChange) { return { criticality: { - level: removedSpecialDirective(args.meta.removedDirectiveName, CriticalityLevel.Breaking), + level: removedSpecialDirective(args.meta.removedDirectiveName, CriticalityLevel.Dangerous), reason: `Directive '${args.meta.removedDirectiveName}' was removed from interface '${args.meta.interfaceName}'`, }, type: ChangeType.DirectiveUsageInterfaceRemoved, @@ -525,7 +525,7 @@ function buildDirectiveUsageScalarRemovedMessage( export function directiveUsageScalarRemovedFromMeta(args: DirectiveUsageScalarRemovedChange) { return { criticality: { - level: removedSpecialDirective(args.meta.removedDirectiveName, CriticalityLevel.Breaking), + level: removedSpecialDirective(args.meta.removedDirectiveName, CriticalityLevel.Dangerous), reason: `Directive '${args.meta.removedDirectiveName}' was removed from scalar '${args.meta.scalarName}'`, }, type: ChangeType.DirectiveUsageScalarRemoved,