Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

term information incomplete in API #202

Open
tmtmtmtm opened this issue Aug 10, 2015 · 1 comment
Open

term information incomplete in API #202

tmtmtmtm opened this issue Aug 10, 2015 · 1 comment

Comments

@tmtmtmtm
Copy link

http://kansanmuisti.fi/api/v1/member/107/ only has terms: ["2011"], although he started in 2009 (as can be seen from his committee posts, and party_associations.

Or is terms only meant to include people who were there for the whole period / since the beginning of the period?
tmtmtmtm added a commit to everypolitician-scrapers/finland-eduskunta-kansanmuisti that referenced this issue Aug 10, 2015
@tmtmtmtm
Ignore KM 'terms'
831e412 
These don’t include memberships that start mid-term
(kansanmuisti/kamu#202), so instead just find
all terms that overlap with the party associations.
@tmtmtmtm
Copy link
Author

This also means that http://kansanmuisti.fi/api/v1/member/134/ has a completely empty terms list.

tmtmtmtm added a commit to everypolitician/everypolitician-data that referenced this issue Aug 10, 2015
@tmtmtmtm
Finland: add some missing memberships
6610a1c 
Rebuild after fresh Morph run to find the memberships that were missing
due to kansanmuisti/kamu#202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tmtmtmtm