From c156764f161d87edcd7056f209b927fb36957897 Mon Sep 17 00:00:00 2001 From: Dan Vargas Date: Thu, 15 Feb 2024 18:35:46 -0700 Subject: [PATCH] property override fix #2474 --- karate-core/src/main/java/com/intuit/karate/Runner.java | 1 - .../test/java/com/intuit/karate/SystemPropertiesTest.java | 8 ++++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/karate-core/src/main/java/com/intuit/karate/Runner.java b/karate-core/src/main/java/com/intuit/karate/Runner.java index 789d80017..7f09a43c3 100644 --- a/karate-core/src/main/java/com/intuit/karate/Runner.java +++ b/karate-core/src/main/java/com/intuit/karate/Runner.java @@ -288,7 +288,6 @@ public T systemProperty(String key, String value) { if (systemProperties == null) { systemProperties = new HashMap(); } - System.setProperty(key, value); systemProperties.put(key, value); return (T) this; } diff --git a/karate-core/src/test/java/com/intuit/karate/SystemPropertiesTest.java b/karate-core/src/test/java/com/intuit/karate/SystemPropertiesTest.java index 8460ccd0a..b76ea75ef 100644 --- a/karate-core/src/test/java/com/intuit/karate/SystemPropertiesTest.java +++ b/karate-core/src/test/java/com/intuit/karate/SystemPropertiesTest.java @@ -21,6 +21,8 @@ void testSystemPropertiesSetOnRunner() { builder.resolveAll(); String propertyValue = builder.systemProperties.get(TEST_PROP); assertEquals(propertyValue, "setOnRunner"); + String jvmValue = System.getProperty(TEST_PROP); + assertEquals(jvmValue, null); } @Test @@ -30,6 +32,8 @@ void testSystemPropertiesSetOnJVM() { builder.resolveAll(); String propertyValue = builder.systemProperties.get(TEST_PROP); assertEquals(propertyValue, "setOnJVM"); + String jvmValue = System.getProperty(TEST_PROP); + assertEquals(jvmValue, "setOnJVM"); } @Test @@ -38,9 +42,9 @@ void testPrecedenceOfSystemPropertiesSetOnRunnerAndJVM() { Builder builder = Runner.builder().systemProperty(TEST_PROP, "setOnRunner"); builder.resolveAll(); String propertyValue = builder.systemProperties.get(TEST_PROP); - assertEquals(propertyValue, "setOnRunner"); + assertEquals(propertyValue, "setOnJVM"); String jvmValue = System.getProperty(TEST_PROP); - assertEquals(jvmValue, "setOnRunner"); + assertEquals(jvmValue, "setOnJVM"); } }