Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pin colour detection to browser #225

Open
wellemut opened this issue Aug 14, 2024 · 0 comments
Open

Move pin colour detection to browser #225

wellemut opened this issue Aug 14, 2024 · 0 comments
Assignees
Labels
01 refactoring not a new function but a rewrite of an existing function on https://v0.kartevonmorgen.org/ 20 frontend Changes in Frontend required

Comments

@wellemut
Copy link
Member

Problem

A clear and concise description of the bug.

for the rate limit issue I can move the tag-color matching to the client's browser instead of server.
Pros: less rate limit, if we change the balloon's color while users are browsing, they won't see the changes in realtime unless they refresh the page.
Cons: will consume user's memory and if the list of color tags grow they may face halted situations.

my recommendation: move the tag-color matching to the browser instead of server because when the csv is small it works on the fly. but we keep the api as well in case we needed to rollback to the server edition.

what do you suggest?

@wellemut wellemut added the 0 bug Something isn't working label Aug 14, 2024
@wellemut wellemut self-assigned this Aug 14, 2024
@wellemut wellemut added 20 frontend Changes in Frontend required 01 refactoring not a new function but a rewrite of an existing function on https://v0.kartevonmorgen.org/ and removed 0 bug Something isn't working labels Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 refactoring not a new function but a rewrite of an existing function on https://v0.kartevonmorgen.org/ 20 frontend Changes in Frontend required
Projects
Status: New Issues
Development

No branches or pull requests

2 participants