Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirection-Script form old to new URLs #94

Closed
7 tasks done
wellemut opened this issue Feb 4, 2022 · 24 comments
Closed
7 tasks done

Redirection-Script form old to new URLs #94

wellemut opened this issue Feb 4, 2022 · 24 comments
Assignees
Labels
0 bug Something isn't working

Comments

@wellemut
Copy link
Member

wellemut commented Feb 4, 2022

Old Parameters

https://blog.vonmorgen.org/en/iframe/

old parameters

New Parameters

@navid-kalaei
Copy link
Collaborator

done on commit 399830d

@wellemut
Copy link
Member Author

wellemut commented Feb 23, 2022

@wellemut
Copy link
Member Author

wellemut commented Feb 23, 2022

Test 2 Businesscard and Map

  1. Old URL: https://kartevonmorgen.org/businesscard.html#/?entry=e8dbf6d028954d6eaa76ad394377c196 and https://kartevonmorgen.org/map.html#/?entry=e8dbf6d028954d6eaa76ad394377c196&zoom=9.00
  2. With dev. https://dev.kartevonmorgen.org/businesscard.html#/?entry=e8dbf6d028954d6eaa76ad394377c196 or https://dev.kartevonmorgen.org/map.html#/?entry=e8dbf6d028954d6eaa76ad394377c196&zoom=9.00
  3. redirects just back to https://kartevonmorgen.org/businesscard.html#/?entry=e8dbf6d028954d6eaa76ad394377c196, and https://kartevonmorgen.org/map.html#/?entry=e8dbf6d028954d6eaa76ad394377c196&zoom=9.00 which is ok untill we have the final domain v0.kartevonmorgen.org/businesscard.html#/?entry=e8dbf6d028954d6eaa76ad394377c196
    ✔️
  • @navid-kalaei I created the subdomain v0.kartevonmorgen.org with a temporay redirection to kartevonmorgen.org, but your script could already run on v0....

@wellemut
Copy link
Member Author

wellemut commented Feb 23, 2022

Test 4 fixedTag

  1. Old URL: https://kartevonmorgen.org/#/?center=49.056,9.382&zoom=7.00&fixedTags=werkzeugkastenwandel
  2. With dev. https://dev.kartevonmorgen.org/#/?center=49.056,9.382&zoom=7.00&fixedTags=werkzeugkastenwandel
  3. redirects to https://dev.kartevonmorgen.org/m/main?c=49.0560%2C9.3820&z=7.00&fixedTags=werkzeugkastenwandel which is a correct translation in the URL, but there is no fixed Tag
    ❌ failed! fixedTag seems not to be implemented yet
  • Make sure, that all fixedTags get added in the URL as tags and shown in the tag-field, so at least the filter is not lost
  • implement fixedTags as intended.

@wellemut
Copy link
Member Author

wellemut commented Feb 23, 2022

@wellemut
Copy link
Member Author

wellemut commented Feb 23, 2022

@wellemut
Copy link
Member Author

wellemut commented Feb 23, 2022

@wellemut
Copy link
Member Author

Test 9 Hashtag

  1. Old URL: https://kartevonmorgen.org/#/?center=50.677,11.602&zoom=7.00&search=%23ideenerfahren17&dropdowns=kvm
  2. with dev: https://dev.kartevonmorgen.org/#/?center=50.677,11.602&zoom=7.00&search=%23ideenerfahren17&dropdowns=kvm
  3. redirects to https://dev.kartevonmorgen.org/m/kvm?c=50.6770%2C11.6020&z=7.00&tag=ideenerfahren17 which is principally correct, just that the sidebar is wider so that the pins are covered by the sidebar, different than in the old version.
    ✔️

@wellemut
Copy link
Member Author

wellemut commented Feb 23, 2022

Test 10 left=hide

  1. Old URL: https://kartevonmorgen.org/#/?center=50.990,6.691&zoom=7.00&search=%23ideenerfahren17&left=hide&dropdowns=kvm
  2. with dev.: https://dev.kartevonmorgen.org/#/?center=50.990,6.691&zoom=7.00&search=%23ideenerfahren17&left=hide&dropdowns=kvm
  3. redirects to: https://dev.kartevonmorgen.org/m/kvm?c=50.9900%2C6.6910&z=7.00&tag=ideenerfahren17&sidebar=hidden which is principally correct, just that there is a bug in the orientation of the pins
    ✔️ URL is correct
    ❌ Pins are wrongly moved to the right:
    grafik
    This would be correct:
    grafik
  • fix the bug with the wrong shift of the map when sidebar is closed. (reloading and zooming solves the problem already now, so its not critical)

@wellemut
Copy link
Member Author

wellemut commented Feb 23, 2022

@navid-kalaei
Copy link
Collaborator

navid-kalaei commented Feb 24, 2022

Thank you very much for your deep careful tests. I'm iterating over the missing parts and here is a briefing:

Test 2

I changed the redirect URLs to v0.kartevonmorgen.org 01f79f8

Test 4

fixed tags are now available 23ab911

Test 5

orgTag is added on commit e77a3e2

Test 10

I could not reproduce the problem. I tested on Brave, FireFox, and Chrome. the rendering is correct on FireFox and Brave, and the pattern of the pins is also correct on Chrome but the location is wrong. so it's a cross platform problem and my guess is, it's related to leaflet. that smells like those bugs that take so much time to detect it's cause. if it's not critical, we could leave it for later.

Brave (correct)

brave - new
brave - original

FireFox (correct)

firefox - new
FireFox - original

Chrome (wrong)

chrome - new
chrome - original

Test 11

now the categories get renamed to type eaec900

Remaining features and fixtures

  • shifting of pins on Google Chrome
  • create entry with preselcted type

navid-kalaei added a commit that referenced this issue Feb 24, 2022
…e the fixed tags should be implemented as intended (#94)
@wellemut
Copy link
Member Author

wellemut commented Feb 27, 2022

  • Allwas show fixed tags as unremovable grey tags in the tagfield
    Just show the tags instead of the "hidden suggestons "search for tags"
    grafik

#62

@wellemut
Copy link
Member Author

orgTag funcitonallity will be working on the productive domain.

@navid-kalaei
Copy link
Collaborator

navid-kalaei commented Apr 23, 2022

the "addentry" param is also added. reference #101 . @wellemut shall we close this issue ?

@wellemut
Copy link
Member Author

wellemut commented Apr 24, 2022

@wellemut
Copy link
Member Author

@alex0107 could you please fix the redirections from old URLs to new ones?
All Mail-Notifications from dev domain contain old urls. Therefore its quite important.

Example: Nein, Eintrag anschauen oder bearbeiten: https://kartevonmorgen.org/#/?entry=c1686515bb954fd590d2fc995d02fca1

@wellemut wellemut reopened this Aug 26, 2023
@alex0107
Copy link
Collaborator

Should work now

@wellemut
Copy link
Member Author

The center and zoom in the redirections stopped working!

Thats why all our old City-Links dont work anymore

Obviously the redirection script does not understand the center and zoom of the old urls anymore...
As it was working before, I think it could be linked to the change of the server @alex0107

@wellemut wellemut reopened this Oct 22, 2023
@wellemut wellemut added the 0 bug Something isn't working label Oct 22, 2023
@alex0107
Copy link
Collaborator

alex0107 commented Oct 28, 2023

Maybe I found a bug:
for example if you use this link:
https://dev.kartevonmorgen.org/#/?entry=a3939c8c8ae44f0e81852eb6931657ef&center=47.653,7.913&zoom=9.00&search=wandel/mapAndEntryList.html#/?center=49.815,8.833&zoom=7.0

No makrer is shown

@wellemut can you please confirm this?

@wellemut
Copy link
Member Author

wellemut commented Oct 29, 2023

Thats a relly strang URL at the end

https://dev.kartevonmorgen.org/#/?entry=a3939c8c8ae44f0e81852eb6931657ef&center=47.653,7.913&zoom=9.00&search=wandel/mapAndEntryList.html#/?center=49.815,8.833&zoom=7.0

grafik

you never have such a searchterm: wandel/mapAndEntryList.html#/?center=49.815,8.833&zoom=7.0 where did you get this from?

No makrer is shown
correct, because its a creazy search!

But normally you would use this URL: https://dev.kartevonmorgen.org/m/main/e/a3939c8c8ae44f0e81852eb6931657ef?c=47.6454%2C7.6963&z=16.00

And your original correct URL

https://dev.kartevonmorgen.org/#/?entry=a3939c8c8ae44f0e81852eb6931657ef&center=47.653,7.913&zoom=9.00&search=wandel

Is perfectly redirecting to https://dev.kartevonmorgen.org/m/main/e/a3939c8c8ae44f0e81852eb6931657ef?c=47.6530%2C7.9130&z=9.00&search=wandel

So technically its all right! Even redirections are working. Perfect!

@wellemut
Copy link
Member Author

On the dev domain, all redirections seem to be working (even fixedTags...)
Please bring the latest version to production! @alex0107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 bug Something isn't working
Projects
Development

No branches or pull requests

3 participants