From 9ff7011a55c269a04b42a71597fb762431a9ffd0 Mon Sep 17 00:00:00 2001 From: Luke Brody Date: Wed, 14 Aug 2024 22:14:27 -0700 Subject: [PATCH] =?UTF-8?q?Don=E2=80=99t=20use=20env?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/check.yml | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index f2b89110c..9086ec1b4 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -1,9 +1,6 @@ name: check on: [push] -env: - REGISTRY: ghcr.io - IMAGE_NAME: ${{ github.repository }}/e2e - BRANCH_NAME: ${{ github.head_ref || github.ref_name }} +# can't use `env` since it doesn't work in e2e.steps[0].uses jobs: lint: runs-on: ubuntu-22.04 @@ -27,7 +24,7 @@ jobs: - name: Log in to the Container registry uses: docker/login-action@v3 with: - registry: ${{ env.REGISTRY }} + registry: ghcr.io username: ${{ github.actor }} password: ${{ secrets.GITHUB_TOKEN }} @@ -35,7 +32,7 @@ jobs: id: meta uses: docker/metadata-action@v5 with: - images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }} + images: ghcr.io/${{ github.repository }}/e2e - name: Build and push Docker image uses: docker/build-push-action@v6 @@ -51,4 +48,4 @@ jobs: runs-on: ubuntu-22.04 needs: build-and-push-image steps: - - uses: docker://${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ env.BRANCH_NAME }} + - uses: docker://ghcr.io/${{ github.repository }}/e2e:${{ github.head_ref || github.ref_name }}