Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: make /readyz /live /healthz /version available in every workspace #2036

Open
1 task
sttts opened this issue Sep 20, 2022 · 3 comments
Open
1 task

feature: make /readyz /live /healthz /version available in every workspace #2036

sttts opened this issue Sep 20, 2022 · 3 comments
Assignees
@bipuladh
Labels
area/server Everything around `kcp start` help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@sttts
Copy link
Member

sttts commented Sep 20, 2022

Feature Description

The mentioned endpoints should return the same status as the global one.

Proposed Solution

Redirect those endpoints under a workspace URL to the top-level one. This could implemented via a function WithPerWorkspaceStaticEndpoints in https://github.com/kcp-dev/kcp/blob/main/pkg/server/handler.go, and wired into the handler chain.

Alternative Solutions

No response

Want to contribute?

  • I would like to work on this issue.

Additional Context

Note: /openapi and /metrics are different and need more thoughts.
@sttts sttts added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. area/server Everything around `kcp start` labels Sep 20, 2022
@csams csams added this to kcp Sep 20, 2022
@csams csams moved this to New in kcp Sep 20, 2022
@sttts sttts moved this from New to Backlog in kcp Sep 20, 2022
@bipuladh
Copy link
Contributor

I would like to work on this if no one is working on it.

@bipuladh
Copy link
Contributor

/assign @bipuladh

@vincepri
Copy link
Contributor

@bipuladh are you still working on this?

@vincepri vincepri mentioned this issue Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bipuladh bipuladh

Labels
area/server Everything around `kcp start` help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
kcp
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌱 Add per-cluster static endpoint filter/handler
3 participants
@sttts @vincepri @bipuladh