Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pause metric in prometheus for scaledjob #5140

Closed
geoffrey1330 opened this issue Oct 30, 2023 · 11 comments
Closed

Add pause metric in prometheus for scaledjob #5140

geoffrey1330 opened this issue Oct 30, 2023 · 11 comments
Labels
feature-request All issues for new features that have not been committed to needs-discussion stale All issues that are marked as stale due to inactivity

Comments

@geoffrey1330
Copy link
Contributor

Proposal

Currently, Prometheus does not provide a dedicated metric for monitoring the pause and resume events of ScaledJobs in Kubernetes. We propose adding a new metric specifically designed to track the pause and resume actions of ScaledJobs. This metric will offer valuable insights into the scaling behavior and pause-related events, improving observability and facilitating troubleshooting.

Use-Case

The addition of a pause metric in Prometheus for ScaledJobs will improve monitoring, simplify troubleshooting, and aid optimization efforts. This metric provides insight into pause and resume events, streamlining the identification of issues and enabling data-driven optimizations. It is a valuable feature for those managing ScaledJobs in Kubernetes clusters.

Is this a feature you are interested in implementing yourself?

Yes

Anything else?

No response

@geoffrey1330 geoffrey1330 added feature-request All issues for new features that have not been committed to needs-discussion labels Oct 30, 2023
@geoffrey1330
Copy link
Contributor Author

@zroubalik I created a new issue similar to this PR here but for scaledjob

@geoffrey1330
Copy link
Contributor Author

If this is OK.
I can proceed working on it

@geoffrey1330
Copy link
Contributor Author

@zroubalik WDYT about the issue?

@zroubalik
Copy link
Member

This should be coordinated with: #4913

@geoffrey1330
Copy link
Contributor Author

@zroubalik Does that Imply I can't work on it. as it should be a part of #4913

@zroubalik
Copy link
Member

@geoffrey1330 wait till the PR is merged. If it is not covered there, let's proceed here 🙏

@geoffrey1330
Copy link
Contributor Author

@zroubalik Alright I will do that.
In the meantime could you recommend any issue for me to work on.

Copy link

stale bot commented Jan 1, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Jan 1, 2024
Copy link

stale bot commented Jan 9, 2024

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Jan 9, 2024
@github-project-automation github-project-automation bot moved this from To Triage to Ready To Ship in Roadmap - KEDA Core Jan 9, 2024
@zroubalik zroubalik reopened this Jan 10, 2024
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Jan 10, 2024
@github-project-automation github-project-automation bot moved this from Ready To Ship to Proposed in Roadmap - KEDA Core Jan 10, 2024
Copy link

stale bot commented Mar 10, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Mar 10, 2024
Copy link

stale bot commented Mar 21, 2024

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Mar 21, 2024
@github-project-automation github-project-automation bot moved this from Proposed to Ready To Ship in Roadmap - KEDA Core Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion stale All issues that are marked as stale due to inactivity
Projects
Archived in project
Development

No branches or pull requests

2 participants