Add a comment once e2e finishes

[zroubalik]

Proposal

In order to be able to tell which e2e test run has passed, we should generate a new comment instead of just adding an emoji to the original comment (the one with /run-e2e command). The new comment should quote the original comment so we have a reference.

The benefit is, that we get a notification that e2e test run has finished, so we can check the results.

Old Proposal (we don't want to go this direction)

In order to be able to tell which PR is ready for final review/merge, it would be nice if a label (eg e2e-passed) could be added to the PR.

If the there are additional commits/pushes to the PR, the label should be automatically removed.

[JorTurFer]

Isn't it enough just the CI check?

[zroubalik]

Maybe 🤔

I am thinking how to do a review properly, once I trigger e2e test on a couple of PRs, I want to get back to these once they finish.

Most likely we can disregard this idea.

[JorTurFer]

Currently we can see if e2e has passed (or being skipped) here:

Red cross or orange circle means failures or in-progress checks
But we can try with the labels

[zroubalik]

Yeah I know, maybe this is more about me, knowing when a new e2e test execution finished, so I can review the result. Sometimes it is hard to keep track. I should probably solve this on my side, the label is an overkill.

[zroubalik]

@JorTurFer what would actually help is to get some kind of notification once the e2e run finishes. Now it just updates a comment which is not something that generates notifications.

[JorTurFer]

Actually, the notification is sent on every comment

[JorTurFer]

We could try to notify somehow to a slack channel. Could it help? If yes, we have to request the slack channel in kubernetes workspace

[zroubalik]

Actually, the notification is sent on every comment

It is not sent on comments updates, or am I mistaken? I am interested in getting a notification once e2e test run finishes.

Slack notification is probably an overkill.

[tomkerkhove]

Actually, the notification is sent on every comment

It is not sent on comments updates, or am I mistaken? I am interested in getting a notification once e2e test run finishes.

Slack notification is probably an overkill.

I can see value in a comment post or so indeed

[zroubalik]

Modified the proposal to create a new comment, instead of just a label.

[tomkerkhove]

I think we should use the same for starting e2e tests instead of updating the message with test run link given that does not trigger GitHub notification, but it might be just me.

[zroubalik]

The comment should mention whether the e2e passed or not, if not, it should also print the failed tests.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.