Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AWS RDS credential secrets or just encrypted JSON in AWS TriggerAuth #6312

Open
sneljo1 opened this issue Nov 6, 2024 · 2 comments
Assignees
Labels
aws All issues concerning integration with AWS feature-request All issues for new features that have not been committed to good first issue Good for newcomers help wanted Looking for support from community

Comments

@sneljo1
Copy link

sneljo1 commented Nov 6, 2024

Proposal

There is a option in secretsmanager to store RDS credentials. This are stored in a fixed format, a key/value object with keys username, password, engine, host, port, dbClusterIdentifier. It would be nice to be able to 1-1 map these properties to the properties triggers.

AS I currently understand it, the full value of the response will be mapped to the parameter right now.

Use-Case

Our use-case would be to directly map this to postgres triggers, but generically, this could also serve different use-cases where users have their own JSON encrypted and need it for different triggers.

Is this a feature you are interested in implementing yourself?

No

Anything else?

No response

@sneljo1 sneljo1 added feature-request All issues for new features that have not been committed to needs-discussion labels Nov 6, 2024
@JorTurFer
Copy link
Member

I thought that there was a feature request to support encrypted json to parse the json and pass a given item from inside the json to the scaler. I think that this is something that definitively we should support as it's an AWS Secrets Manager capability

@JorTurFer JorTurFer added help wanted Looking for support from community good first issue Good for newcomers aws All issues concerning integration with AWS and removed needs-discussion labels Nov 6, 2024
@pravarag
Copy link

pravarag commented Nov 9, 2024

Hi @JorTurFer , I'd like to take this up if anyone else hasn't started on it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws All issues concerning integration with AWS feature-request All issues for new features that have not been committed to good first issue Good for newcomers help wanted Looking for support from community
Projects
Status: To Triage
Development

No branches or pull requests

3 participants