-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up setuptools and wheel requirements to align with PEP-518 #1559
Comments
We will reassess how much effort this is and exactly what's involved once we've split all our test requirements etc. following the creation of kedro-datasets. If we remove our requirements for pip-tools then maybe we can remove our dependency on setuptools altogether. |
When #2152 is addressed, I guess the build requirements would only be specified in the PEP 518 |
@astrojuanlu Is there any more work that needs to be done here, or is it completed with #2152 as you commented above? |
I think we should be able to safely remove them from scripts and files used for development, namely: Lines 10 to 11 in 7dcb60c
Lines 108 to 109 in 7dcb60c
kedro/dependency/requirements.txt Line 21 in 7dcb60c
kedro/tools/circleci/requirements.txt Line 2 in 7dcb60c
However, there are other mentions related to |
Okay cool, thanks for the clarification! In that case let's get #2413 in the next sprint and complete that first. |
To make sure I understand, this issue is about the Kedro CI, and #2350 is about the Kedro runtime dependencies, right? (The latter being a bit more difficult because of #2350 (comment)) |
Closed in #2927 |
We've got
"setuptools>=38.0"
andwheel
requirements in various other places in the repo (just do a Ctrl+F to see them). Does this mean we can remove them from there?If yes then that would be nice but a bit of a bigger change, so probably worth doing in a separate PR.
Originally posted by @AntonyMilneQB in #1542 (comment)
The text was updated successfully, but these errors were encountered: