Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long posts should have the View More feature #249

Closed
lauchaves opened this issue Jul 23, 2024 · 3 comments · Fixed by #290
Closed

Long posts should have the View More feature #249

lauchaves opened this issue Jul 23, 2024 · 3 comments · Fixed by #290
Assignees
@lauchaves
Labels
frontend good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lauchaves
Copy link
Contributor

Description

Issue

  • Long posts take a lot of space on the screen, sometimes a lot of scrolling as well

Expected

  • Long posts should have the View More feature

Screenshots

image
@ugur-eren ugur-eren assigned ugur-eren and unassigned ugur-eren Jul 23, 2024
@ugur-eren ugur-eren added good first issue Good for newcomers help wanted Extra attention is needed frontend labels Jul 23, 2024
@ugur-eren
Copy link
Collaborator

This issue can be assigned to contributors who want to implement it.s

Post content should be sliced after 200 characters and add a text button with see more... label should be displayed. Upon clicking the button whole post will be viewed.

@lauchaves
Copy link
Contributor Author

This issue can be assigned to contributors who want to implement it.s

Post content should be sliced after 200 characters and add a text button with see more... label should be displayed. Upon clicking the button whole post will be viewed.

@ugur-eren I can work on this as well 🚀

lauchaves pushed a commit to lauchaves/joyboy that referenced this issue Jul 25, 2024
keep-starknet-strange#249: Long posts should have the see more feature
0944cdf
@lauchaves lauchaves mentioned this issue Jul 25, 2024
Merged
lauchaves pushed a commit to lauchaves/joyboy that referenced this issue Jul 25, 2024
keep-starknet-strange#249: Long posts should have the see more feature
320466a
@lauchaves
Copy link
Contributor Author

JM @ugur-eren this is ready for review! Here's the PR

@ugur-eren ugur-eren linked a pull request Jul 25, 2024 that will close this issue
#249: Long posts should have the see more feature #290
Merged
ugur-eren pushed a commit that referenced this issue Jul 25, 2024
@lauchaves
#249: Long posts should have the see more feature (#290)
83edcf5 
Co-authored-by: lauchaves <[email protected]>
This was referenced Oct 31, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lauchaves lauchaves

Labels
frontend good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#249: Long posts should have the see more feature lauchaves/joyboy
2 participants
@lauchaves @ugur-eren