-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimum Qt version? #10859
Comments
We are bumping it to 5.12 then 6.6 (I think that's the current lts) |
Bump the minimum required Qt version up to 5.12, as per keepassxreboot#10859 (comment). Previously, the minimum version was 5.2.0 based on the CMakeLists.txt check, though it's unclear if such old versions would actually work. With this, we are able to remove a whole bunch of #ifdef'd code.
Bump the minimum required Qt version up to 5.12, as per keepassxreboot#10859 (comment). Previously, the minimum version was 5.2.0 based on the CMakeLists.txt check, though it's unclear if such old versions would actually work. With this, we are able to remove a whole bunch of #ifdef'd code.
Bump the minimum required Qt version up to 5.12, as per keepassxreboot#10859 (comment). Previously, the minimum version was 5.2.0 based on the CMakeLists.txt check, though it's unclear if such old versions would actually work. With this, we are able to remove a whole bunch of #ifdef'd code.
Bump the minimum required Qt version up to 5.12, as per keepassxreboot#10859 (comment). Previously, the minimum version was 5.2.0 based on the CMakeLists.txt check, though it's unclear if such old versions would actually work. With this, we are able to remove a whole bunch of #ifdef'd code.
Bump the minimum required Qt version up to 5.12, as per #10859 (comment). Previously, the minimum version was 5.2.0 based on the CMakeLists.txt check, though it's unclear if such old versions would actually work. With this, we are able to remove a whole bunch of #ifdef'd code.
Bump the minimum required Qt version up to 5.12, as per keepassxreboot#10859 (comment). Previously, the minimum version was 5.2.0 based on the CMakeLists.txt check, though it's unclear if such old versions would actually work. With this, we are able to remove a whole bunch of #ifdef'd code.
What was the last version to support Qt4 by the way? |
Not keepassxc |
That’s unfortunate. I will see if Qt4-based build can be fixed, at least in a minimal config. |
Qt-4 has been end of life for almost a decade KeePassX (the predecessor to this project) is built for Qt-4 |
@droidmonkey Yeah, I know that the legacy app was for Qt4. Unfortunately, Qt5+ is broken for some platforms, while Qt4, regardless of EOL status, works perfectly fine. |
The minimum supported Qt version is always the one that comes with the lowest Ubuntu version for which we ship PPA packages. |
What is the project's minimum required Qt version at this point? It would be nice to state this somewhere for reference.
As I said in my original PR description for #7783, I've been assuming 5.9.5 as the minimum version, as that was stated in INSTALL.md at the time; but as of #10088, it no longer mentions a minimum version requirement. Instead, we now have:
keepassxc/vcpkg.json
Lines 37 to 40 in c81e4e1
But also:
keepassxc/CMakeLists.txt
Lines 515 to 517 in c81e4e1
(Currently, my #7783 includes a commit to change the above to require 5.9.5.)
I ask because there are a bunch of
QT_VERSION_CHECK
s in the code (including some new ones in #7783), some of which could potentially be deleted now, depending on the minimum Qt version we want to impose. I'd be happy to submit a PR for that cleanup, if I knew which Qt version to target. (Of course, we eventually want to migrate to Qt 6, in #10267, but that might be a while yet I imagine.)The text was updated successfully, but these errors were encountered: