diff --git a/README.md b/README.md index d33cdb4..b487d41 100644 --- a/README.md +++ b/README.md @@ -119,7 +119,7 @@ The `error` returned by `Validate()` has structured data with information on the ``` golang v := validator.NewValidator(client, spec) err := v.Validate() -if vErr, ok := err.(*validator.ValidationError); ok { +if vErr, ok := err.(validator.ValidationError); ok { fmt.Printf("Validation failed for %s/%s/%s.\n", vErr.GVR.Group, vErr.GVR.Version, vErr.GVR.Resource) diff --git a/pkg/client/types.go b/pkg/client/types.go index 63bd388..4b18c2d 100644 --- a/pkg/client/types.go +++ b/pkg/client/types.go @@ -118,7 +118,7 @@ type ValidationError struct { ConditionValidations []ConditionValidationResult } -func (e *ValidationError) Error() string { +func (e ValidationError) Error() string { fieldValidationResult, _ := json.MarshalIndent(e.FieldValidations, "", "\t") conditionValidationResult, _ := json.MarshalIndent(e.ConditionValidations, "", "\t") return fmt.Sprintf("%v.\nGVR: %s/%s/%s.\nField Validation Results: %s\nCondition Validation Results: %s", e.Message, diff --git a/pkg/client/validator.go b/pkg/client/validator.go index d7dff41..4d8f25f 100644 --- a/pkg/client/validator.go +++ b/pkg/client/validator.go @@ -83,7 +83,7 @@ func (v *Validator) Validate() error { prettyPrintStruct(summary) } if r.Required { - v.Waiter.errors <- &ValidationError{ + v.Waiter.errors <- ValidationError{ Message: errors.Errorf("failure threshold met for resource '%v'", resourceName), GVR: groupVersionResource(r.APIVersion, r.Name), FieldValidations: summary.FieldValidation,