Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKAN 2.9 compatibility #1

Open
ThrawnCA opened this issue Jan 7, 2022 · 4 comments
Open

CKAN 2.9 compatibility #1

ThrawnCA opened this issue Jan 7, 2022 · 4 comments

Comments

@ThrawnCA
Copy link

ThrawnCA commented Jan 7, 2022

Hi :)

We're looking to update our qld-gov-au/ckanext-qa fork to be compatible with CKAN 2.9, and I see that there are some branches in this repo that have started work on it, by @duskobogdanovski and @HristijanVilos

Any indication of how close it is to being ready? I'm happy to help out, this is the next piece of work for me, but our fork isn't going to be directly compatible for merging, because we have unrelated changes.

@ThrawnCA
Copy link
Author

ThrawnCA commented Jan 7, 2022

I notice that in the migration to Click commands, Paster support appears to have been entirely dropped. Ideally the extension would continue to support both. Not only does this increase its usefulness for sites that have not yet updated, it also allows any existing 2.8-based test suites to continue functioning, increasing confidence that regression failures have not been introduced.

@HristijanVilos
Copy link
Member

Hi

We were doing migration work for one of our clients portals, but due to time constrains we made the extension work only with CKAN 2.9 and to our specific case. If we do some additional work in the future, we will make sure to send a pull request to your repository.

@ThrawnCA
Copy link
Author

I ended up just going ahead and starting from scratch in our fork, rather than merging from your branch. Not sure whether it will be of much use to you, but feel free to take a look if you want. qld-gov-au#23

@ThrawnCA
Copy link
Author

Okay, we've cut a release: https://github.com/qld-gov-au/ckanext-qa/releases/tag/2.0.3-qgov.4

Automatic merge isn't possible, but there are few things you might want to manually copy, eg:

  • More Python 3 compatibility (print with brackets, using six.text_type instead of str)
  • Retaining Paster compatibility
  • Using UTC timestamps internally so that they can be consistently localised on output
  • GitHub Actions continuous integration testing with Docker and Behave

natemago pushed a commit that referenced this issue Nov 1, 2022
AV-1274: Translate report info in templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants