Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove our hacky implementation of "Tags" #75

Open
kelyvin opened this issue Feb 23, 2019 · 2 comments
Open

Remove our hacky implementation of "Tags" #75

kelyvin opened this issue Feb 23, 2019 · 2 comments

Comments

@kelyvin
Copy link
Owner

kelyvin commented Feb 23, 2019

As the title states, with the latest Ghost version, we no longer need our hacky management of tags. Leverage Ghost's setup instead.

@BaankeyBihari
Copy link
Contributor

Can you elaborate more on this? Where do you want the tag implementation to change? post.hbs or tag.hbs

@kelyvin
Copy link
Owner Author

kelyvin commented Mar 7, 2019

I was referring to the tags overlay that appears when you click on the search button on the top right-hand corner of the page.

The list of tags that appears is hard coded from the following code setting:

var tag_names = ['code', 'career'];

I want to remove this hard-coded array of tags, and instead pull the list of registered tags from ghost's content API.

This will be a step away from how this theme was implemented (which assumes no API is provided by Ghost), but it'll be for the better. This will serve as the starting point for all future API integrations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants