Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy Button Block #470

Open
gsambrotta opened this issue Apr 18, 2024 · 1 comment
Open

Remove legacy Button Block #470

gsambrotta opened this issue Apr 18, 2024 · 1 comment
Assignees
Labels
improvement For improving existing features, refactoring, and general house keeping

Comments

@gsambrotta
Copy link
Collaborator

In the code there is a button-block.component.ts which is not used anywhere.
It is confusing to have it there as we do have button in the UI but they are under the Action Block.

We should clean up the code and avoid further confusion.
We should remove:

  • src/app/blocks/button-block

Remove it from here:
src/app/components/blocks-workflow/blocks-workflow.component.html

  97:    import {ButtonBlockComponent} from './blocks/button-block/button-block.component';

And here:
/home/anaketa/repos/Kendraio/kendraio-app/src/app/app.module.ts

  15: <app-button-block class="block-wrapper" *ngSwitchCase="'button'" [context]="context" [config]="block" [model]="models[i]" (output)="updateModel(i + 1, $event)"></app-button-block>
@gsambrotta gsambrotta added the improvement For improving existing features, refactoring, and general house keeping label Apr 18, 2024
@gsambrotta gsambrotta self-assigned this Apr 18, 2024
@CodeKrakken
Copy link
Collaborator

Agreed - if it definitely isn't used it should go. Are you sure it's obsolete?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement For improving existing features, refactoring, and general house keeping
Projects
None yet
Development

No branches or pull requests

2 participants