Skip to content
This repository has been archived by the owner on Feb 6, 2025. It is now read-only.

Running the linting script with --diff raises additional linting errors #825

Open
pmantica1 opened this issue May 13, 2020 · 0 comments
Open
Labels
maintainer quality-of-life Features that ease development, but are not necessarily visible to package users.

Comments

@pmantica1
Copy link
Contributor

pmantica1 commented May 13, 2020

During linting we run the pydocstyle command twice with different configurations: once for the testing files and once for the non-testing files. When we are linting all of the files in the repo, we pass wildcard characters and the identification of files as test and non-test files happens internally within pydocstyle through the pattern matching we specify in the .pydocstyle configuration files. When we are only linting the files with changes, we pass in a list of filenames. By passing in a list of file names, we tell pydocstyle: "forget the match patterns we specified in the configuration files and lint all of the files we provided as input". So both pydocstyle commands lint all of the input files when we run scripts/lint.sh ---diff. This is why we see additional linting errors.

@pmantica1 pmantica1 added the maintainer quality-of-life Features that ease development, but are not necessarily visible to package users. label May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainer quality-of-life Features that ease development, but are not necessarily visible to package users.
Projects
None yet
Development

No branches or pull requests

1 participant