Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Configuration options for parallel downloads and cellular data #14

Open
uzegonemad opened this issue Apr 12, 2024 · 3 comments

Comments

@uzegonemad
Copy link

uzegonemad commented Apr 12, 2024

It would be great if we could set some configuration options for this library. Two that come to mind are the ability to set the number of parallel downloads, and choosing whether to download with Cellular data or just WiFi.

(As always, I can open a PR when time allows, but I like to post these in case anyone else gets there before me)


Edit: It looks like the Android Cellular Data portion is already supported in the form of the isAllowedOverMetered option. I wasn't paying enough attention to the documentation. Still, I think we should abstract this to a shared setting/function that can be used both on iOS and Android.

@uzegonemad
Copy link
Author

Following up on this, setMaxParallelDownloads appears to be specific to ExoPlayer/Media3's implementation of a Download Manager and isn't actually native functionality. That might make implementing on this library a little more difficult, but I do still believe it would be beneficial to have.

My app may queue several hundred (possibly even around 1,000) downloads at once, and it would be ideal to specify that I only want 2-3 to download at a time.

@kesha-antonov
Copy link
Owner

Actually these are good thoughts. We have max parallel downloads thing in our project. Not implemented in this lib yet

@uzegonemad
Copy link
Author

@kesha-antonov I know you're really busy right now - I'm wondering if you are able to send me the code you're using for parallel downloads? I'll see if I can work it into a PR for this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants