Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurssion Control is not correct #28

Open
fbouzeraa opened this issue Feb 5, 2020 · 3 comments
Open

Recurssion Control is not correct #28

fbouzeraa opened this issue Feb 5, 2020 · 3 comments

Comments

@fbouzeraa
Copy link

fbouzeraa commented Feb 5, 2020

Hi,
First of all I want to thank you Kevin for this great work.

In fact I discuvred some issue, the control of recurssion is based on the triggerHandler name not the exact event (Before Insert, Before Update, ...), so by this way, you w'll stop other events from running. Say for example if the before insert is running and by some way another event must run, so the control w'll stop it. we aleready encountred this scenarion.

Please find attached my proposed correction and tell me if you think I have right.
https://gist.github.com/fbouzeraa/29f6b84e7a93c3c39b20631b89a97f8d
Best regards,

@eyavorovenko
Copy link

eyavorovenko commented Feb 13, 2020

Hey @fbouzeraa, would you mind to provide your solution as a link to a gist instead of a zip archive?

@fbouzeraa
Copy link
Author

Hi @eduardyav,
this is : https://gist.github.com/fbouzeraa/29f6b84e7a93c3c39b20631b89a97f8d
Best regards,

@wrone
Copy link

wrone commented Sep 27, 2021

I also encountered this issue, didnt expect that it will count method executions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants