Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for non-standard commitlint config location for v2 #22

Open
1 task done
ismay opened this issue Jul 3, 2024 · 4 comments
Open
1 task done

Allow for non-standard commitlint config location for v2 #22

ismay opened this issue Jul 3, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@ismay
Copy link

ismay commented Jul 3, 2024

Is there an existing request for this?

  • I have searched the existing feature requests

Is the feature request related to a problem?

Our commitlint config is not in the standard location (long story). I see that for v2 specifying the commit location has been dropped. That means we'll have to copy the config to the standard location, when it would be more convenient to just point to where it is.

Is the feature request related to a existing bug/RFC?

No response

Describe the solution you'd like

Allow cl-config option again.

What is the definition of done?

When cl-config has been added back, or an equivalent feature or solution exists.

Any solutions considered?

No response

Are you able to assist to bring the feature to reality?

Yes, I can

Anything else?

No response

@ismay ismay added the enhancement New feature or request label Jul 3, 2024
@ismay
Copy link
Author

ismay commented Jul 3, 2024

Actually, feel free to close this. I ended up just going with directly using commitlint cli on CI, so this is no longer needed.

@kevintyj
Copy link
Owner

kevintyj commented Jul 4, 2024

@ismay I'm actually genuinely curious what the use case of a non-standard commitlint config location would be? Is this a common use case? I would not mind spending a day to add the ability back...

@kevintyj
Copy link
Owner

kevintyj commented Jul 4, 2024

The best case scenario use case of the v2 use case is if you do not have any external rulesets you rely on, or have a compiled config, you can dramatically reduce action times compared to using the cli command on a node environment (37sec -> 16sec for me), compared to using the cli command, which I believe would be much slower as dependencies would have to be fetched...

@ismay
Copy link
Author

ismay commented Jul 4, 2024

@ismay I'm actually genuinely curious what the use case of a non-standard commitlint config location would be? Is this a common use case? I would not mind spending a day to add the ability back...

To be honest, I don't think you should add it just on behalf of my specific usecase, as it's a pretty rare one. We have an npm package with the config for distributing it amongst the org. So I'm passing the path to that config. It's not that standard and I'm satisfied just running the cli, so if you ask me I think you should save yourself the trouble of catering to an esoteric usecase. But it's up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants