Skip to content
This repository has been archived by the owner on Sep 24, 2023. It is now read-only.

is detach() required? #20

Open
sujoyp opened this issue Nov 4, 2018 · 0 comments
Open

is detach() required? #20

sujoyp opened this issue Nov 4, 2018 · 0 comments

Comments

@sujoyp
Copy link

sujoyp commented Nov 4, 2018

There seems to be a detach() in location_network() while obtaining mu from h_t. Same thing for the baseline or value estimation. Is this required? If yes, then essentially, the log_prob loss is not training the RNN, but only the fc layer for mu computation.
Is this correct?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant