Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove local kssh config file #99

Open
mmou opened this issue May 8, 2020 · 0 comments
Open

remove local kssh config file #99

mmou opened this issue May 8, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mmou
Copy link
Contributor

mmou commented May 8, 2020

with moving the kssh config file from KBFS to the KV store, we may not need the client config file for improving performance, so we should consider removing this complexity.

maybe i'm missing something, but with this no longer an issue, there's really not much value to having a client config file at all. all of that persistent state isn't nearly as valuable as the added complexity of having some configs sometimes in a file and getting them there and checking for them. the way this thing is used, most people are going to be hitting the same servers and the same bot every time, so if kssh only exposed kssh --bot yourcabot <rest of command> in the event you were in multiple teams with ca-bots, you just write your own alias once (e.g. kssh-prod) and never think about it again, and then kssh gets the added benefit of being basically stateless (excepting your non-kssh ssh configs).

not a task for this PR. but the move from kbfs->kvstore seems like it offers some additional opportunities.

Originally posted by @xgess in #97

@mmou mmou added enhancement New feature or request good first issue Good for newcomers labels May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant