Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two mappings conflict (but logically they don't), and the first one was not executed as expected. #1271

Closed
2 of 4 tasks
lkchx123 opened this issue Aug 7, 2024 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@lkchx123
Copy link

lkchx123 commented Aug 7, 2024

Developer TODO (don't remove)

  • create new branch. put issue number at start of name if not a very quick fix.
  • write tests. put issue number in comment
  • update documentation
  • merge and delete branch (don't squash because want commit history to see why I made changes)

Discord message link/email recipient
email: [email protected]

Describe the bug
Two mappings conflict (but logically they don't), and the first one was not executed as expected.

To Reproduce
Steps to reproduce the behavior:
As shown in the screenshot of the mappings, the first mapping won't be executed on any page. While the second mapping can be executed in Bilibili (in line with the settings).

Upload a backup of your keymaps.
mappings_20240808-063240.zip

Expected behavior
On any page except those in the Yuzu application, the X button should be mapped as the flashlight on. On the pages in Bilibili, double-clicking the X button should be mapped as volume down.

Screenshots
Screenshot_2024-08-08-06-34-09-244_io github sds100 keymapper

Smartphone (please complete the following information):

  • Device: Redmi K70
  • Android version: Android 14

Additional context
key_mapper_log_20240808-064233.txt

This is the execution log (including the extra log)
. I clicked the X button in the Bilibili application. The first mapping was not executed. Then I double-clicked the X button and the second mapping was executed. Besides, if the second mapping is turned off, the first mapping can be executed normally. Therefore, they conflict.

@lkchx123 lkchx123 added the bug Something isn't working label Aug 7, 2024
@sds100
Copy link
Collaborator

sds100 commented Sep 29, 2024

Bug confirmed :)

@sds100 sds100 added this to the Version 2.6 milestone Sep 29, 2024
@sds100 sds100 moved this to In progress in Key Mapper Sep 29, 2024
sds100 added a commit that referenced this issue Oct 1, 2024
@sds100
Copy link
Collaborator

sds100 commented Oct 1, 2024

fixed

@sds100 sds100 closed this as completed Oct 1, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Key Mapper Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants