Option 'Skip legacy verified users' unchecks after updates

[alcayaga]

I'm not certain how to offer additional evidence, but I suspect there is a connection between extension updates and the 'Skip legacy verified users unchecks when updating' unchecking itself

This is the second instance where I've noticed this option was unchecked, despite my recollection of having checked it previously and not changing it. Interestingly, other settings appear unaffected.

I am sorry I can't provide more information at this moment. However, if helpful, I am willing to assist in diagnosing this issue further.

[kheina]

I only see one location to a place where we disable the skiplegacy option:

Blue-Blocker/src/shared.ts

Line 567 in 8ed9701

const timeout = setTimeout(disableSkipLegacy, 1000); // 1 second. indexed db is crazy fast (<10ms), this should be plenty

you may not have an answer to this question, and that's ok, but do you know if you a) have users in the queue and b) have a twitter tab open during the BB version update?

the only situation I can see where this gets accidentally disabled is if the update occurs during a block and that timeout above never gets cancelled as it should

[rougetimelord]

Closing for now, feel free to reopen if it happens again or you find out new information about what caused this.

[cooljeanius]

Closing for now, feel free to reopen if it happens again or you find out new information about what caused this.

...do we know which version in particular was affected?

[alcayaga]

Sorry for the delay in responding.

Since Firefox updates the extension automatically, I can't be certain if there were users in the queue and a Twitter tab open during the updates. However, it is likely, as I usually have a Twitter tab open.

I will monitor the situation and report back if I encounter this issue with the upcoming release. Thanks for your assistance!

[kheina]

Sorry for the delay in responding.

Since Firefox updates the extension automatically, I can't be certain if there were users in the queue and a Twitter tab open during the updates. However, it is likely, as I usually have a Twitter tab open.

I will monitor the situation and report back if I encounter this issue with the upcoming release. Thanks for your assistance!

thanks! just to chime in here, the skip legacy users option is one of the few that can actually disable itself since it relies on an idb database that runs in the background script. while I didn't foresee any issues with the db lookup since it's very quick, if the addon were to update at the same time as a lookup, that might cause a failure and make the extension turn off the setting

Blue-Blocker/src/shared.ts

Lines 663 to 677 in 014ad8d

	// group for skip-verified option
	config.skipVerified &&
	(await new Promise((resolve, reject) => {
	// basically, we're wrapping a promise around a promise to set a timeout on it
	// in case the user's device was unable to set up the legacy db
	function disableSkipLegacy() {
	api.storage.sync.set({ skipVerified: false });
	reject(legacyDbRejectMessage);
	}
	const timeout = setTimeout(disableSkipLegacy, 1000); // 1 second. indexed db is crazy fast (<10ms), this should be plenty
	IsUserLegacyVerified(user.rest_id, user.legacy.screen_name)
	.then(resolve)
	.catch(disableSkipLegacy)
	.finally(() => clearTimeout(timeout));
	}))

we could probably just remove the disable legacy code and just pop an error instead and it would probably fix this

[alcayaga]

I received the update and the checkbox disabled by itself again. I can confirm I didn't have any user in the queue

Using Edge 125.0.2535.51 on Windows 10

[alcayaga]

Maybe it's not the updates that trigger this behavior. I checked the settings on the same computer, and it's unchecked again with the same version of the extension.

Could there be some kind of synchronization of the settings that might trigger this as well?

[kheina]

I don't understand, it's still checked here?