Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from: search prefix 500s when the supplied account cannot be found #36

Closed
aescling opened this issue Apr 5, 2022 · 2 comments · Fixed by #37
Closed

from: search prefix 500s when the supplied account cannot be found #36

aescling opened this issue Apr 5, 2022 · 2 comments · Fixed by #37
Assignees
Labels
LV.1: Application Backend @ installing and running the application LV.3: HTML Serialization @ HTML webpage renedering LV.3: Mastodon API Serialization @ the Mastodon API LV.5: Interface Frontend @ User interface STATUS: bug Improper behaviour STATUS: refactor Things should be said differently

Comments

@aescling
Copy link
Contributor

aescling commented Apr 5, 2022

see mastodon/mastodon#17941

importing here as my WIP commits keep spamming the issue upstream

@aescling aescling added STATUS: bug Improper behaviour STATUS: refactor Things should be said differently STATUS: need info Further information is requested LV.3: Mastodon API Serialization @ the Mastodon API LV.3: HTML Serialization @ HTML webpage renedering labels Apr 5, 2022
@aescling aescling self-assigned this Apr 5, 2022
@aescling
Copy link
Contributor Author

aescling commented Apr 5, 2022

945c9b1 strictly solves the issue and also changes behavior in ways i personally find preferable. it litters changes across the codebase and i don’t know if i like that

i think the way i raise errors to handle the problem is very sketch; i would like to better understand the control flow for text search so i can handle things in a more idiomatic- and cleaner-feeling way

i would like to see the search API capable of sending error responses; and i would like to see the front end not just throw them at the toast, probably displaying such errors in the search results column

@aescling
Copy link
Contributor Author

aescling commented Apr 5, 2022

mastodon/mastodon#17963

@aescling aescling added LV.5: Interface Frontend @ User interface and removed STATUS: need info Further information is requested labels Apr 8, 2022
@aescling aescling linked a pull request Apr 9, 2022 that will close this issue
@aescling aescling added the LV.1: Application Backend @ installing and running the application label Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LV.1: Application Backend @ installing and running the application LV.3: HTML Serialization @ HTML webpage renedering LV.3: Mastodon API Serialization @ the Mastodon API LV.5: Interface Frontend @ User interface STATUS: bug Improper behaviour STATUS: refactor Things should be said differently
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant