Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Darkmode"-compatibility of views #22

Closed
julrich opened this issue Feb 21, 2024 · 0 comments · Fixed by #23
Closed

"Darkmode"-compatibility of views #22

julrich opened this issue Feb 21, 2024 · 0 comments · Fixed by #23
Assignees
@lmestel
Labels
enhancement New feature or request

Comments

@julrich
Copy link
Member

julrich commented Feb 21, 2024

Currently it's next to impossible to read some of the text we display in the addon, when the Storybook itself is themed to be dark, e.g.:
image

We should either a) make this dynamic in the addon, or use the correct token contextually, or b) just remove custom theming, isolating the views and always displaying them in light mode
@julrich julrich added the enhancement New feature or request label Feb 21, 2024
@lmestel lmestel linked a pull request Feb 28, 2024 that will close this issue
Connect validation tab with editor #23
Merged
@lmestel lmestel closed this as completed Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmestel lmestel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Connect validation tab with editor kickstartDS/storybook-addon-jsonschema
2 participants
@julrich @lmestel