Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Unable to clear the uploaded attachments. #11

Open
robert1112 opened this issue May 2, 2023 · 7 comments
Open

[BUG]: Unable to clear the uploaded attachments. #11

robert1112 opened this issue May 2, 2023 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@robert1112
Copy link

Describe the bug
Error message after remove the attachment and hit clear button.

To Reproduce

  1. Remove the attachment from sidebar by clicking x
  2. Hit Clear of the attachment field
  3. The error message

Expected behavior
Attachment is cleared and allow to upload

Screenshots
Shot 2023-05-03 at 01 23 41

Desktop (please complete the following information):
ERPNext: v14.22.0 (version-14)
Frappe Framework: v14.33.0 (version-14)
Frappe Better Attach Control: v2.0.0 (main)

Additional context
None.

@robert1112 robert1112 added the bug Something isn't working label May 2, 2023
@kid1194
Copy link
Owner

kid1194 commented May 2, 2023

@robert1112 Thanks a lot for reporting this bug..

I will fix it and get back to you..

Sorry for any inconvenience..

Best regards..

@kid1194
Copy link
Owner

kid1194 commented May 3, 2023

@robert1112 I have updated the plugin, so please update too and check if you can clear the attachments or not..

Best regards..

@robert1112
Copy link
Author

@kid1194 thank you. Can you take a look at this ? Thank you.
#9 (comment)

@kid1194
Copy link
Owner

kid1194 commented May 5, 2023

@robert1112 Apparently it's not allowed to add a custom field to the core DocType..

I have updated the plugin and in case there is a problem with clearing the attachments, a message will be post to the browser console so please give it a try..

I thought of a solution for the options field problem that I want to share with you.

Do you think that it would be better if there is a plugin doctype that controls every aspect of the plugin?
Like the plugin's status (Enabled/Disabled), the doctypes where the plugin is active and the plugin options for each attach field in these doctypes.

Or should the plugin rely on the Options field which is much easier?

I will update the plugin soon which should fix everything..

Best regards

@kid1194
Copy link
Owner

kid1194 commented May 5, 2023

@robert1112 I have updated the plugin so please update and give it a try..

Use the default options field to set the settings..

Best regards..

@kid1194
Copy link
Owner

kid1194 commented May 19, 2023

@robert1112 I just want to check if everything is working well or there are still some bugs..

Best regards..

@maliknaqibullah
Copy link

@kid1194 I got the same issue with frappe version 15

image

is there any way to fix this?

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants