Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with @playform/compress #81

Open
thwonghin opened this issue Jun 8, 2024 · 2 comments
Open

Compatibility with @playform/compress #81

thwonghin opened this issue Jun 8, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers sri SubResource Integrity

Comments

@thwonghin
Copy link

Hi, thank you for this project!

I tried this integration together with another integration https://github.com/PlayForm/Compress which will compress the resources and make the hashes produced by this integration invalid.

Is there anyway to workaround to make both integrations together?

@castarco castarco added enhancement New feature or request sri SubResource Integrity labels Sep 11, 2024
@castarco
Copy link
Contributor

Hi @thwonghin I'm not sure if there is any good workaround, as I haven't gone through this particular use case. I might do some small experiments these next days.

@castarco castarco added the good first issue Good for newcomers label Sep 11, 2024
@castarco
Copy link
Contributor

castarco commented Oct 1, 2024

Hi @thwonghin , in the last release (v1.6.1) I changed how the astro:build:done hook is configured, ensuring that it's executed as late as possible.

This should help avoiding the problems related to file hashes changes, could you check if this is solved now? Thank you :) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers sri SubResource Integrity
Projects
None yet
Development

No branches or pull requests

2 participants