Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

az-cvm-vtpm: vtpm::VerifyError is unused and redundant #42

Closed
mkulke opened this issue Dec 14, 2023 · 1 comment
Closed

az-cvm-vtpm: vtpm::VerifyError is unused and redundant #42

mkulke opened this issue Dec 14, 2023 · 1 comment
Labels
kind/bug Something isn't working

Comments

@mkulke
Copy link
Member

mkulke commented Dec 14, 2023

Description

az-cvm-vtpm: vtpm::VerifyError is unused and redundant. The actual error enum is in vtpm::verify::VerifyError. Removing this will be breaking change, because it's exposed publicly.

Impact

It's confusing for users.

Environment and steps to reproduce

n/a

Expected behavior

az-cvm-vtpm: vtpm::VerifyError should not be available.
@mkulke mkulke added the kind/bug Something isn't working label Dec 14, 2023
@mkulke mkulke mentioned this issue Jan 15, 2024
Merged
@mkulke
Copy link
Member Author

mkulke commented Jan 16, 2024

closed by #47

@mkulke mkulke closed this as completed Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mkulke