Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll Lost on Safari #71

Open
jon-sully opened this issue Jan 3, 2025 · 2 comments
Open

Scroll Lost on Safari #71

jon-sully opened this issue Jan 3, 2025 · 2 comments

Comments

@jon-sully
Copy link

Hello! Thank you for all of the work on this library. I just wanted to report that the scroll position doesn't seem to be maintained, even on v2.0.0, when using Safari (v18.2) 😕 it does seem to work on Chromium browsers, but not Safari.

Cheers!

@MSchmidt
Copy link

MSchmidt commented Jan 7, 2025

Cannot confirm. I've just migrated to v2 and Safari (v18.2) is keeping the scroll position just as it did with <2. Did you change the turbo-track fields as mentioned in the README?

@jon-sully
Copy link
Author

Our stylesheet_link_tag is data_turbo_track: Rails.env.production? ? "reload" : "" but we also have javascript_importmap_tags — are you using import maps?

I may have just found my own answer from another issue in this repo I apparently commented on several months ago:

#56 (comment)

It looks like using javascript_importmap_tags bakes in / forces "data-turbo-track": "reload" under the hood ☹️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants