Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<button> tag is semantically wrong element for a11y #15

Open
jackahl opened this issue Jan 30, 2024 · 0 comments
Open

<button> tag is semantically wrong element for a11y #15

jackahl opened this issue Jan 30, 2024 · 0 comments
Assignees
Labels
a11y Additions to fix accessibility issues

Comments

@jackahl
Copy link
Member

jackahl commented Jan 30, 2024

We should replace the element at

<Button className={(cx('button'), data.align)}>
or set a as="span" prop because semantically this block is just a link and not a html button. Having buttons within links is very confusing when navigating the page via keyboard and definitely a a11y violation.

@jackahl jackahl added the a11y Additions to fix accessibility issues label Jan 30, 2024
@jackahl jackahl self-assigned this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Additions to fix accessibility issues
Projects
None yet
Development

No branches or pull requests

1 participant