Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It should be possible to edit/delete comments #5702

Closed
pontus-osterdahl opened this issue Jun 27, 2023 · 6 comments · Fixed by #5703 or #5785
Closed

It should be possible to edit/delete comments #5702

pontus-osterdahl opened this issue Jun 27, 2023 · 6 comments · Fixed by #5703 or #5785

Comments

@pontus-osterdahl
Copy link
Contributor

Is your feature request related to a problem? Please describe.
To the best of my knowledge, it is currently not possible to delete or edit the content of existing "non-correction" comments.

Describe the solution you'd like
It should be possible to edit and delete "non-correction" existing "non-correction" comments.

Additional context
Since the effects of "correction comments" on workflow etc are more complex, the possibility of editing/deleting them should be handled separately.

@matthias-ronge
Copy link
Collaborator

I find it good; but if someone has already replied to the comment, you shouldn't be able to edit it, or operators who read the thread later will get confused.

@pontus-osterdahl
Copy link
Contributor Author

That's a good point, perhaps only the most recent comment should be editable?

@henning-gerhardt
Copy link
Collaborator

Should be there not at least some roles / rights for editing and / or deleting comments? Without them it is possible for every user to edit / delete the comments.

@pontus-osterdahl
Copy link
Contributor Author

I agree. I would tend to allow at least the author of the comment to edit and delete it. We could also add further authorities (edit and delete comments on client and global level) to allow users to edit/delete any comments.

@solth
Copy link
Member

solth commented Jul 11, 2023

I agree. I would tend to allow at least the author of the comment to edit and delete it. We could also add further authorities (edit and delete comments on client and global level) to allow users to edit/delete any comments.

That sounds like a good idea. For allowing the author to edit his own comments we wouldn't even require additional permissions, but this could be extended later to allow additional users with special authorities to edit comments of other users.

@BartChris
Copy link
Collaborator

BartChris commented Jan 9, 2025

I find it good; but if someone has already replied to the comment, you shouldn't be able to edit it, or operators who read the thread later will get confused.

I just worked on an extended permission system for deleting comments. #6363

The rule to allow edits only on the last comment is quite problematic since comments not necessarily represent a "thread" but could just be different comments. So in a "non-thread" constellations i cannot delete an older comment because it is not the last comment, even if the comments are totally unrelated. The current behaviour encodes assumptions about a specific usage of the system, which are not necessarily true.

In addition to that: When the first comment is a "correction comment" it is impossible to delete older "normal" comments.

What should we do here? I would suggest, that at least the person with additional rights should be able to delete every info comment. What do you think?
For normal users without additional privleges i would suggest: if the first comment is a correction comment, it should definitely be possible to delete the latest info comment, if we want to keep the current behaviour.
But ideally i would prefer if users can delete all of their comments. They know best, when and why to delete a comment, even if it means sabotaging a thread. We should not prevent that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants