Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare spiTimerTickStart and spiTimerTickDelay as static #9

Open
vpreatoni opened this issue Jan 15, 2022 · 1 comment
Open

Declare spiTimerTickStart and spiTimerTickDelay as static #9

vpreatoni opened this issue Jan 15, 2022 · 1 comment

Comments

@vpreatoni
Copy link

Hi!
great work!! I've seen very crappy code regarding SD SPI and STM32 but yours is very clean and tidy.

Just a suggestion, declare instead:

static uint32_t spiTimerTickStart;
static uint32_t spiTimerTickDelay;

They are not used outside user_diskio_spi.c file, so it is a good practice declare them static globals.

@kiwih
Copy link
Owner

kiwih commented Mar 16, 2022

Hi there, you can submit a PR with this if you would like, I will accept it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants