Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: assert correct gas charging of static opcodes #892

Open
enitrat opened this issue Sep 3, 2024 · 0 comments
Open

tests: assert correct gas charging of static opcodes #892

enitrat opened this issue Sep 3, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@enitrat
Copy link
Collaborator

enitrat commented Sep 3, 2024

Currently, static opcodes (whose gas consumption doesn't depend on external factors) are tested, asserting the correct values are pushed on the stack.

We should also test that the gas used is correct.
Concretely, just add an assert_eq! on the gas left after execution
@enitrat enitrat added the enhancement New feature or request label Sep 3, 2024
@enitrat enitrat mentioned this issue Sep 3, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Kakarot's Project Management
Status: 🆕 Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@enitrat