Skip to content
This repository has been archived by the owner on Jan 8, 2025. It is now read-only.

tests: assert correct gas charging of static opcodes #892

Open
enitrat opened this issue Sep 3, 2024 · 0 comments
Open

tests: assert correct gas charging of static opcodes #892

enitrat opened this issue Sep 3, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@enitrat
Copy link
Contributor

enitrat commented Sep 3, 2024

Currently, static opcodes (whose gas consumption doesn't depend on external factors) are tested, asserting the correct values are pushed on the stack.

We should also test that the gas used is correct.
Concretely, just add an assert_eq! on the gas left after execution
@enitrat enitrat added the enhancement New feature or request label Sep 3, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Kakarot on Starknet Sep 3, 2024
@enitrat enitrat mentioned this issue Sep 3, 2024
Merged
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
Kakarot on Starknet
Status: 🆕 Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@enitrat