Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ElementClassifier implementations #11

Open
naslundx opened this issue Jul 5, 2020 · 0 comments
Open

Refactor ElementClassifier implementations #11

naslundx opened this issue Jul 5, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@naslundx
Copy link
Collaborator

naslundx commented Jul 5, 2020

Move logic from Workflow._run_element_classifiers to classifier classes themselves, since there’s no reason for it to be hidden in Workflow object.

Would be cool if the method got simplified/split in the process.

Same for Workflow._highlight_classifier_result

Same for BinaryFilter evaluation
@naslundx naslundx added the enhancement New feature or request label Nov 26, 2020
@naslundx naslundx mentioned this issue Dec 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@naslundx