Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider validation of LFH #3

Open
klausbrunner opened this issue Feb 20, 2023 · 0 comments
Open

Consider validation of LFH #3

klausbrunner opened this issue Feb 20, 2023 · 0 comments

Comments

@klausbrunner
Copy link
Owner

klausbrunner commented Feb 20, 2023

Right now the LFH content isn't validated at all - we just check if the CFH points to a location with the necessary LFH signature. This is deliberate as there seem to be many files in the wild with subtle discrepancies between the headers.

It could make sense to compare the CRC-32s between central and local headers, but need to be careful in the Data Descriptor case (e.g. CFH contains CRC-32, but LFH doesn't because it's in a Data Descriptor?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant