Merge pull request #33 from johanobergman/fix/update-when-removing-items

Fix getQueriesToUpdate when mutation has fewer array items than the cached data
klis87 · Nov 30, 2024 · 74193ab · 74193ab
2 parents 48cebd5 + 8e6a829
commit 74193ab
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/packages/normy/src/create-normalizer.spec.ts b/packages/normy/src/create-normalizer.spec.ts
@@ -683,6 +683,29 @@ describe('createNormalizer', () => {
       ]);
     });
 
+    it('returns query if mutation array and query array are of different length', () => {
+      const normalizer = createNormalizer();
+      normalizer.setQuery('query', {
+        id: '1',
+        list: [1, 2],
+      });
+
+      expect(
+        normalizer.getQueriesToUpdate({
+          id: '1',
+          list: [1],
+        }),
+      ).toEqual([
+        {
+          queryKey: 'query',
+          data: {
+            id: '1',
+            list: [1],
+          },
+        },
+      ]);
+    });
+
     it('works with equal date objects', () => {
       const normalizer = createNormalizer();
 

diff --git a/packages/normy/src/create-normalizer.ts b/packages/normy/src/create-normalizer.ts
@@ -20,8 +20,8 @@ const isMutationObjectDifferent = (
   normalizedData: Data,
 ): boolean => {
   if (Array.isArray(mutationData) && Array.isArray(normalizedData)) {
-    if (mutationData.length === 0) {
-      return normalizedData.length !== 0;
+    if (mutationData.length !== normalizedData.length) {
+      return true;
     }
 
     return mutationData.some((v, i) =>