Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WantDeleteCollections was never implemented in TableTest #2455

Open
mattmoor opened this issue Mar 10, 2022 · 5 comments
Open

WantDeleteCollections was never implemented in TableTest #2455

mattmoor opened this issue Mar 10, 2022 · 5 comments
Labels
area/API area/networking area/test-and-release kind/bug Categorizes issue or PR as related to a bug. kind/good-first-issue Denotes an issue ready for a new contributor. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@mattmoor
Copy link
Member

/area API
/area networking
/area test-and-release
/kind bug
/kind good-first-issue

Expected Behavior

A TableTest with WantDeleteCollections verifies things work!

Actual Behavior

It silently ignores DeleteCollection calls.

See also:

pkg/reconciler/testing/table.go

Line 75 in d2cdc68

WantDeleteCollections []clientgotesting.DeleteCollectionActionImpl

@knative-prow-robot knative-prow-robot added area/API area/networking area/test-and-release kind/bug Categorizes issue or PR as related to a bug. kind/good-first-issue Denotes an issue ready for a new contributor. labels Mar 10, 2022
@mattmoor
Copy link
Member Author

Ok, I'm like 90% sure that this isn't currently possible because of: kubernetes/kubernetes#105357

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 8, 2022
@github-actions github-actions bot closed this as completed Jul 8, 2022
@mattmoor
Copy link
Member Author

mattmoor commented Jul 8, 2022

/lifecycle frozen

@knative-prow knative-prow bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 8, 2022
@mattmoor
Copy link
Member Author

mattmoor commented Jul 8, 2022

/reopen

@knative-prow knative-prow bot reopened this Jul 8, 2022
@knative-prow
Copy link

knative-prow bot commented Jul 8, 2022

@mattmoor: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/API area/networking area/test-and-release kind/bug Categorizes issue or PR as related to a bug. kind/good-first-issue Denotes an issue ready for a new contributor. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattmoor @knative-prow-robot