From 43f752622190e565df60bb9c1327dfd87c67d199 Mon Sep 17 00:00:00 2001 From: Kenjiro Nakayama Date: Mon, 28 Aug 2023 17:26:01 +0900 Subject: [PATCH] Do not skip TestTargetBurstCapacity when `dataplane-trust` is not specified (#14300) * Do not skip TestTargetBurstCapacity when `dataplane-trust` is not specified * use empty string * Use dataplane-trust instead of internal-encryption * Revert "Use dataplane-trust instead of internal-encryption" This reverts commit 1acfacc617a84753d70047a348d0cfbdefb5c7e3. * Add deprecated internal-encryption * Fix --- test/e2e/autoscale_test.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/test/e2e/autoscale_test.go b/test/e2e/autoscale_test.go index 86c3d133e52a..bf4d985401ef 100644 --- a/test/e2e/autoscale_test.go +++ b/test/e2e/autoscale_test.go @@ -173,9 +173,11 @@ func TestTargetBurstCapacity(t *testing.T) { if err != nil { t.Fatal("Fail to get ConfigMap config-network:", err) } - if !strings.EqualFold(cm.Data[netcfg.DataplaneTrustKey], string(netcfg.TrustDisabled)) { - // TODO: Remove this when https://github.com/knative/serving/issues/12797 was done. - t.Skip("Skipping TestTargetBurstCapacity as activator-ca is specified. See issue/12797.") + + // TODO: Remove this when "activator always stay in path" is eliminated. + dataplaneTrustMode := cm.Data[netcfg.DataplaneTrustKey] + if (dataplaneTrustMode != "" && !strings.EqualFold(dataplaneTrustMode, string(netcfg.TrustDisabled))) || strings.EqualFold(cm.Data[netcfg.InternalEncryptionKey], "true") { + t.Skip("Skipping TestTargetBurstCapacity as activator always stay in path.") } cfg, err := autoscalerCM(ctx.clients)