Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vegeta rates / targets to SLA in performance tests #14403

Closed
ReToCode opened this issue Sep 20, 2023 · 3 comments · Fixed by #14429
Closed

Add Vegeta rates / targets to SLA in performance tests #14403

ReToCode opened this issue Sep 20, 2023 · 3 comments · Fixed by #14429
Assignees
@xiangpingjiang
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/enhancement triage/accepted Issues which should be fixed (post-triage)

Comments

@ReToCode
Copy link
Member

ReToCode commented Sep 20, 2023 •
edited
Loading

Context

PR #14289 made performance tests work again. There has been some discussion on follow-up improvements.

Needed work

Add new SLAs to each tests, making sure the defined vegeta rates/total requests are met, so that tests fail when the throughput and/or expected request rate cannot be met.

Discussion here
@ReToCode ReToCode added kind/enhancement triage/accepted Issues which should be fixed (post-triage) help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Sep 20, 2023
@ReToCode ReToCode mentioned this issue Sep 20, 2023
Merged
3 tasks
@xiangpingjiang
Copy link
Contributor

/assign

@ReToCode
Copy link
Member Author

@xiangpingjiang feel free to work on it, but be aware that the PR is not yet merged: #14289, so make sure to base your work on that PR.

@dprotaso
Copy link
Member

#14289 has merged now

@xiangpingjiang xiangpingjiang mentioned this issue Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiangpingjiang xiangpingjiang

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/enhancement triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Vegeta rates / targets to SLA in performance tests xiangpingjiang/serving
3 participants
@dprotaso @ReToCode @xiangpingjiang