Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panics/errors on previous benchmarks should be ignored #16

Open
dcu opened this issue Feb 6, 2020 · 2 comments
Open

Panics/errors on previous benchmarks should be ignored #16

dcu opened this issue Feb 6, 2020 · 2 comments

Comments

@dcu
Copy link

dcu commented Feb 6, 2020

When the benchmarks in the base commit fails they should be just ignored and not make everything fail
mauriciocm9 pushed a commit to mauriciocm9/cob that referenced this issue Feb 7, 2020
feat: ignore previous benchmark if exit in error (knqyf263#16)
ae97006
mauriciocm9 pushed a commit to mauriciocm9/cob that referenced this issue Feb 7, 2020
feat: ignore previous benchmark if exit in error (knqyf263#16)
053ea1d
@mauriciocm9 mauriciocm9 mentioned this issue Feb 8, 2020
Open
mauriciocm9 added a commit to mauriciocm9/cob that referenced this issue Feb 8, 2020
@mauriciocm9
Merge pull request #1 from mauriciocm9/feat-ignore-errors-previous-be…
6f04693 
…nchmark-16

feat: ignore previous benchmark if exit in error (knqyf263#16)
@knqyf263
Copy link
Owner

I'm sorry for the late reply. Now, cob ignores "no packages to test" error. Let me know other failing case, please. I can't imagine how the base commit fails for any other reason.

@dcu
Copy link
Author

dcu commented Feb 18, 2020

this can be produced if the benchmark has a fixed dependency that changed or was broken with the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dcu @knqyf263