-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support Policy, update tests and release a new tag #66
Comments
no, it means that the team might decide not to use any feature of go1.22 and instead consider only the subset of features that were already present in go1.21. I don't think this policy is followed strictly these days. It still means that we start at 1.22. |
Thanks! That makes sense. In such case we do not need to support |
Updated issue according to comment above by Edoardo. |
- Update tests Closes knqyf263#66 Signed-off-by: Alex In <[email protected]>
- Update tests Closes knqyf263#66 Signed-off-by: Alex In <[email protected]>
- Update tests Closes knqyf263#66 Signed-off-by: Alex In <[email protected]>
Hi @knqyf263
I finally had time to look into issue mentioned in this thread.
I can't reproduce this problem on my systems. Have tried Ubuntu 22.04 and older Ubuntu 20.04. Installed
go1.20.14
+tinygo-v0.29.0
(same as in failing tests), and all passed when runningmake test
.And there is also at least one example when test on
tinygo-v0.29.0
did PASS on github runner -> here.At the moment there is one example of failing test with
tinygo-v0.29.0
-> here.I think it could be sort of flaky test related to particular version of
tinygo
, or maybe related to environment (github runner). No evidence of failing tests on moderntinygo
versions so far.Since
go-plugin
itself is built on top of Wazero, I think first of all it makes sense to clarify its compatibility policy. For instance, Wazero says following:So for the current version of Go (
go1.23
), it'sgo1.23
andgo1.22
. What I don't quite get is next sentence:Does that mean that currently Wazero also supports
go1.21
? Maybe @evacchi could clarify this point.Update: answered in comment:
So I think that
go-plugin
compatibility policy needs to be in line with Wazero. Ifgo1.21
is least supported version, then same should go forgo-plugin
.There is also good document which describes mapping between big Go and
tinygo
versions, but unfortunately, outdated. Opened an issue about it.According to
tinygo
releases pagetinygo-v0.29.0
supports Go up to 1.21.If above correct, then taking in account Wazero support policy, this version still needs to be supported,however oncego1.24
is released it should be dropped and tests fortinygo-v0.29.0
removed.I would like to propose following (updated):
go-plugin
support policy explaining that it goes in line with Wazerotinygo
versions (0.32.0
and0.33.0
), since minimal Go version supported by Wazero at the moment is 1.22, drop support fortinygo-v0.29.0
and remove corresponding test0.32.0
and0.33.0
The text was updated successfully, but these errors were encountered: