-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omega beta 3 #200
Comments
I have the same issue, also logged here: xbmc/xbmc#24869 (comment) |
Here is an extract of your log from open to close of the stream:
|
I’m not an expert in this addon but it looks like kodi is requesting data from the reader and it’s not arriving. Hopefully the maintainer can take a look. |
Problem number 1 is that there should be a version 21.0.0 of this add-on available on the mirrors, which is not the case , because the Windows build of the add-on fails. I think we need to save this problem first. |
should read v21.0.0 installed |
Windows build fails with:
Interestingly, only the 64 bit build fails, not 32 bit. @AlwinEsch any ideas what causes the build error? |
This is a path length problem that has been ongoing to this addon. One of the old builders had this problem. I don’t know if this has been addressed on the new windows VMs. Let me try to dig up the os fix, but if I recall it cause the path length of the file is over 260 bytes. likely the problem there is that something changed in Kodi core that affects the addon API and that’s why the old build from Nexus no longer works in Omega. |
One fix:
can also be set via groups policy: https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry @lrusak or @fuzzard either of you know is this has been down of the new windows build VMs? |
Hi Phunkyfish, I tried to apply the change to the Windows registry as you explained in your previous post. Unfortunately, however, this attempt doesn't work either. I attach the final Kodi Omega 21 log file with the Mediaportal plugin installed and the log. of errors that occur "after" changing the Windows system file. |
I don't know if it can help but I can assure you that from this version onwards the problem certainly occurs: |
Sorry, the change is for the Jenkins builders, that we use to build the addon. It won’t have any effect on your runtime OS. I didn’t make that clear. |
Don't worry it's not a problem |
Version 21.0.0 for win32 and win64 is now available at the official add-on repository. Can you guys please update and report whether the problem still persists with that version? |
Hi Ksooo, unfortunately this version of the pvr.mediaportal.tvserver addon doesn't solve the problem, I've attached the .log file |
Okay, it was worth a try. Then we need to continue the investigation. |
As already said, I tested from version "20240126-b104e068-master-x64.exe" onwards, between the release of Omega Beta 2 and this version I was unable to test because the builds were not present in the nightly versions archive |
Thanks for yous help |
That’s likely a few hundreds commits to look at to see if we can find the offending one. |
@phunkyfish I guess ffmpeg6 |
Won’t take too long if we bisect the builds between beta 2 and 20240126-b104e068-master-x64.exe, at the halfway points each time. ffmpeg6 was added in April 2023, 6.01 in November 2023, and beta 2 is December 20th 2023, so we only have December 20 to Jan 26 to check through. |
It can’t be ffmpeg 6, that’s been there a long time. We’ll need to use Jenkins to create the builds. @JCalvi, if you co-ordinate the commits we build I can generate them. sound like a plan? |
small suggestion, wouldn't it be a good idea to try to compile a build from the first days of January 2024?.. I volunteer to test it and see if it works with the Mediaportal pvr addon, if so we'll go further, this way we'll do it first to narrow the field |
Maybe something changed wrt caching data? Just guessing... Can we see this kind of log entries for Nexus, @MarcoViti ?
Or is this in Nexus logs?
Stream 0 is the video stream! No video stream, no playback. |
@phunkyfish the suspicious |
Yes, I was thinking the same. Just need to find those commits and test before/after. |
No problem, can do. |
Good candidates: xbmc/xbmc#24504 |
@ksooo File .log di kodi versione Nexus 20.5 x64 |
No problem Marco, good luck with NextPVR. |
@phunkyfish and @thexai, All working for me (with Media Portal 2.5 TVE3 & Kodi 21) so as far as i am concerned you can close this issue as fixed. You can pick either of the fixed versions as final as they both worked. |
I can confirm that @phunkyfish version https://jenkins.kodi.tv/job/kodi-pvr/job/pvr.mediaportal.tvserver/job/PR-206/1/artifact/cmake/addons/build/zips/pvr.mediaportal.tvserver+windows-x86_64/pvr.mediaportal.tvserver-21.0.2.zip above is working for me on MP 1.32 and Kodi 21, thanks |
Ok, then that’s a confirmation that the fix in the addon works for MediaPortal 1. @thexai in this case I say we merge the addon fix and say this is done. You ok with that? |
Closed by #206 |
Thanks to all for the work to fix this issue. Have been following this as I have had this problem with live tv on Android (Nvidia Shield) as soon as it updated from Kodi 20.5 to 21. Tested on the local (to MP TV Server) Windows installation and found the same issue (kodi requested bytes v tsreader received bytes mismatch in log) . On the local Windows installation this is now fixed as others have said, but on both remote Windows and Android clients I still get this problem. |
@TechReefer are you able to try with MP2? |
First tried updating MP1 TV server to 1.33 as I thought moving to MP2 might be painful (it was) but still got same issue. Several trip ups later am now on MP2 (2.5 with TVE3 and the updated MP2 plugin) but still have same issue. Throughout this recorded tv has always played ok on the various versions (guess must be something different about live tv). Still looks like same symptom to me but in case it helps here's an extract from remote Windows client (same symptoms on Android) where I tried to play one channel (which works on Kodi 20.5 or MP client). 2024-05-16 16:33:05.389 T:13112 info : Starting Kodi (21.0 (21.0.0) Git:20240406-60c4500054). Platform: Windows NT x86 64-bit |
@thexai the user above has the same issue on MP2 as on MP1. So there must be another reason why the stream fails. Any ideas? |
I'm not sure if in some cases this addon expects use FileCache (e.g. external network/internet source). Probably the best way of keep behavior exact as before is use the new flag Then is worth try: OpenFile(m_fileName, READ_NO_BUFFER) in Omega nightly only. See xbmc/xbmc#25129 the new flag should be defined somewhere in the add-on: static const unsigned int READ_NO_BUFFER = 0x200; |
Other thing to try is change SMB chunk size to 64K in Settings > Services > SMB Client |
Re-opening to track resolution |
Thanks @thexai, we won't have that exposed in the add-on API yet, but I've defined the flag as you suggested in this PR so we can test it: #207. @TechReefer can you grab the add-on build from here: https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.mediaportal.tvserver/detail/PR-207/6/artifacts and a recent Omega nightly from here (by recent I mean the last few days) and let us know how you get on? @JCalvi can you also test this? Would make sense to check your setup continues to function. Assuming it's all good we can release this fix once 21.1 comes out. |
Unfortunately live tv still fails for me. With the latest nightly Kodi build (dated 18th May) and the add-on build linked above (21.0.3) : 2024-05-19 10:50:35.882 T:10192 info : Starting Kodi (21.0 (21.0.1) Git:20240516-86b0c771b9). Platform: Windows NT x86 64-bit I did also try changing the SMB chunk size to 64k as suggested but that made no difference to this issue that I could see. Other video and audio sources (which would use SMB) remain unaffected. |
PS: I am happy to test on my system as soon as @TechReefer has a version considered working. |
That’s not a good kick off point. Right now we need to know if the file cache has any impact on this problem. So without this test on a working system we can’t know that. |
No problem, glad I asked. Will try it out then when I get a chance. |
Ok, tested 21.0.3 plug-in on regular Omega 21.0 and tv worked fine. |
Thank you for testing it. |
So as it stands now we have a working and non working install of MP2. Which does not really help us at all. @TechReefer is your install on a local network? |
Yes my install and all clients are on the local lan, same subnet. I said above that for the local Windows installation this is now fixed, but on both remote Windows and Android clients I still get this problem. To clarify by 'remote clients' I mean devices on the same network but on a different device from the MP server. This means that for both myself and JCalvi the fix for live tv is working when the MP2 server (TVEngine) and the client (Kodi) are on the same box (what I meant by 'local'). However, the fix has not worked for me when the Kodi clients (an Nvidia Shield and a Windows 10 device) are not on the same box as the MP2 server. Both of these were working for live tv on Kodi 20.5. |
@TechReefer have you tested enable/disable "Use RTSP streaming" in add-on client settings / Playback, as others mentions this works:
https://forum.kodi.tv/showthread.php?tid=377722&pid=3200560#pid3200560 |
Interesting. So the problem is caused when the network is involved. On localhost kodi must treat things differently |
That's been my guess for a while. I also mentioned that recorded tv plays fine for me on all clients which maybe suggests that the issue is more specific that just network v local - i.e. the issue seems to be just live tv over network. As regards TSReader with RTSP set to on. The default has always been RTSP off all the way back to at least Kodi 17 when I started using Kodi and the MP PVR add-on. I'd guess the reason may have been that RTSP on has tended to be flaky in my experience. My clients have always been set at the default - so TSReader with RTSP set to off. I did test with RTSP on but, as other users on that thread have commented, although live tv did tune and display, pause, rewind and forward did not work which really negates much of the PVR functionality. Kodi 20.5 clients also have those issues for me when RTSP is set to on. Both live tv and recorded tv are both MPEG transport streams (.ts files) so the only real difference I can see are file sizes - recorded tv files being much larger. Throughout this issue seems to have revolved around tsreader live tv over network. Perhaps something changed from Kodi 20.5 (and many previous versions) in Omega that the MP PVR add-on was relying on for live tv over network to work. I can post more log extracts if it would help. |
I tested this locally and for me all is working fine. Tested in Nexus and Omega in Windows 11 (portable install) and master branch in Nvidia Shield (other host in same LAN). All setups are working with same settings. Steps followed:
In Kodi only enabled add-on with default settings and in others hosts (Shield) replaced default IP 127.0.0.1 with local IP of host where is installed MP2 server (192.168.0.x). Kodi.2024-06-16.18-54-27-00.00.02.452-00.00.19.083-seg1.mp4Kodi.2024-06-16.18-54-27-00.00.20.963-00.00.45.736-seg2.mp4 |
Thanks for posting those steps. Interesting, I didn't know you could add a channel like that. I went through those steps checking that my settings matched. The only pvr add-on setting that was different was 'Fast Channel switching' so I turned that off just in case. On my MP2 server (Windows 11 physical device with TV card and live tv channels) Kodi Omega played the stream successfully as expected (pvr add-on 21.02). There's never been a problem with live tv on the server itself so no reason to think the stream would fail, but I tested anyway. On my remote Windows 10 client (physical device) the stream failed to play with Kodi Omega (21.0). I then replaced the pvr client (which was at the default 21.02) with the 21.03 pvr add-on fix and then the stream played successfully. As before, live tv did not work - spinning wheel and eventually a failed to play message with similar log messages as before - tsreader bytes mismatch. On my Nvidia Shield the stream played successfully with pvr add-on 21.02. As before, live tv did not work - spinning wheel and eventually a failed to play message and similar log messages as before - tsreader bytes mismatch. Log extracts: Windows 10 client (test synthetic mpeg-ts stream channel) : 2024-06-23 09:39:05.583 T:13000 info : Starting Kodi (21.0 (21.0.0) Git:20240406-60c4500054). Platform: Windows NT x86 64-bit Windows 10 client (test live tv channel) : 2024-06-23 09:39:56.097 T:13000 info : VideoPlayer::OpenFile: pvr://channels/tv/TV1@1335748142/[email protected]_1030.pvr Nvidia Shield (test synthetic mpeg-ts stream channel): 2024-06-23 11:32:48.306 T:20857 info : Starting Kodi (21.0 (21.0.1) Git:20240409-7e760d1063). Platform: Android ARM 64-bit Nvidia Shield (test live tv channel) : When playing the mpeg-ts synthetic stream I noticed there is no pause option, only stop. I'm guessing that's because, unlike live tv, this is a DVB-IP stream (as opposed to DVB-S or DVB-T). Obviously there are some differences between the mpeg-ts container components and attributes of the synthetic stream versus live tv but I wouldn't have thought they're relevant (I can post the differences if it is.) If you watch the timeshifting folder on the MP2 server while the synthetic stream is playing there is no live3-0.ts.buffer.ts file being created (as there is with live tv). This is reflected in the logs where you can also see that tsreader is not involved when playing the synthetic stream whereas it is when playing live tv. Although both live tv and the synthetic stream are both mpeg-ts video the mechanism by which they're processed - both at the Kodi and the MP2 server end - is not really the same which may explain why the synthetic stream works but live tv does not. I'm not sure where the problem lies but this does seem to narrow it down to live tv/tsreader over network. All other media stored on the MP2 server (video, music, recorded live tv etc) works on both remote clients. Live TV also works on both remote clients when using Kodi Nexus (20.5.0) and it's pvr add-on version. |
Hey all, could use your help with a PR for updating the settings format for the add-on no functional change, just the internal settings format. Testbuilds in the PR. Please comment on the PR if there are any issues found or if it just works. Thanks in advance. |
The kodi PRs have been merged. Nightlies from Oct 17th will contain the required changes. test builds of the addon can be used with these nightlies for testing the fix. Kodi 22 Piers: https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.mediaportal.tvserver/detail/PR-215/2/artifacts |
Let me start by saying that I didn't have any problems with beta 2. Omega beta 3 gives me problems with viewing the TV.
Apparently everything works, I have the list of channels, the icons and the EPG, I can easily scroll through the entire list of my channels... but when I select one the two wheels in the center of the screen start to turn and the system remains waiting for a few seconds and then stops, as if I had pressed stop
In short, the channel display does not start.
Windows 11 x64 updated to the latest version.
https://paste.kodi.tv/konucegupo.kodi
The text was updated successfully, but these errors were encountered: